Ticket #2773 (closed defect: fixed)

Opened 13 years ago

Last modified 2 years ago

'include' keyword (for command class def) have no effect if it was defined before 'Include' keyword (for commad def).

Reported by: gavenkoa Owned by: andrew_b
Priority: major Milestone: 4.8.29
Component: mc-core Version: master
Keywords: Cc: gavenkoa@…
Blocked By: #4141 Blocking:
Branch state: no branch Votes for changeset:

Description

If I create ~/.config/mc/mc.ext file:

include/video
	Open=echo OK
shell/.avi
    Include=video

and then press RET on .avi file nothing happen.

But if swap this entries I get 'OK' in terminal.


I discover this bug when introduce techniture to merge system wide and own mc.ext file in: #2772 (Suggestion to load /etc/mc/mc.ext before ~/.config/mc/mc.ext anyway or add keyword to mc.ext for this purpose).

For example I want redefine class 'video'. So I put:

include/video
    Open=GOOD-VIEWER %f

then I put content of /etc/mc/mc.ext, which have such lines:

...
### Video ###

regex/\.([aA][vV][iI])$
	Include=video
regex/\.([mM][kK][vV])$
	Include=video

include/video
	Open=BAD_VEWER %f
...

But Open=GOOD-VIEWER %f was ignored and Open=BAD_VEWER %f was taken in account.

Because of this bug I can not just concatenate my settings with system wide, I need use some sed/awk/perl magic...

Change History

comment:1 Changed 13 years ago by gavenkoa

I use MC:

GNU Midnight Commander, версия 4.8.1

from Debian wheezy/sid.

comment:2 Changed 13 years ago by andrew_b

  • Blocking 1677 added

comment:3 Changed 13 years ago by andrew_b

  • Blocking 1677 removed

comment:4 Changed 10 years ago by gavenkoa

  • Cc gavenkoa@… added

comment:5 Changed 2 years ago by andrew_b

  • Blocked By 4141 added

(In #4141) Branch: 4141_mc.ext.ini
Initial changeset:67ec86b570be80da4670b57ae42be4ea71f8bb63

mx.ext was moved to INI format from custom one (yet another step to format unification). This allows to implement a task written in the ticket sunmmary.

This is alsow fixes #2773 and #3742.

comment:6 Changed 2 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.29

comment:7 Changed 2 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:8 Changed 2 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.