Ticket #2767 (closed enhancement: fixed)

Opened 8 years ago

Last modified 7 years ago

[PATCH] A few innocuous and very useful updates for mc.ext

Reported by: birdie Owned by: slavazanko
Priority: major Milestone: 4.8.7
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

  1. Add a few more audio file types for audio
-regex/\.([wW][mM][aA])$
+regex/\.([wW][mM][aA]|[aA][pP][eE]|[aA][aA][cC]|[wW][vV]|[mM]4[aA])$
  1. Simplify WMA handling ( -> Include=audio)
  1. Change audio and video 'View'
-sed -n '/^ID_/p'
+sed -n 's/^ID_//p'

that will hide superfluous ID_ prefix

Attachments

mc.ext.482.diff (1.1 KB) - added by birdie 8 years ago.

Change History

Changed 8 years ago by birdie

comment:1 Changed 8 years ago by andrew_b

  • Blocking 1686 added
  • Blocked By 2118 added

comment:2 Changed 8 years ago by slavazanko

  • Blocked By 2118 removed

(In #2118) merged to master:

git log --pretty=oneline e944301..5c6ae10

comment:3 Changed 7 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Milestone changed from 4.8.3 to 4.8.4

comment:4 Changed 7 years ago by andrew_b

  • Milestone changed from 4.8.4 to 4.8.5

comment:5 Changed 7 years ago by birdie

  • Milestone changed from 4.8.5 to 4.8.6

comment:6 Changed 7 years ago by birdie

BTW, mplayer can "view" pretty much all audio types, so it makes sense to make it a default viewer for all audio and video files.

comment:7 follow-up: ↓ 8 Changed 7 years ago by ossi

it isn't a particularly *good* audio player, though - and at least a while ago, they made a point of it being a *movie* player, not a *media* player, so no change is expected.

comment:8 in reply to: ↑ 7 Changed 7 years ago by birdie

Replying to ossi:

it isn't a particularly *good* audio player, though - and at least a while ago, they made a point of it being a *movie* player, not a *media* player, so no change is expected.

Actually mplayer is the best audio player in Linux as it supports hundreds of options, different filters, output formats, output sinks, volume normalization, etc. No other player is as versatile as mplayer.

It has no GUI, but then there are many GUI players which use MPLayer as a backend.

comment:9 Changed 7 years ago by ossi

yes: as a backend.

comment:10 Changed 7 years ago by andrew_b

  • Blocked By 2897 added

comment:11 Changed 7 years ago by andrew_b

  • Blocked By 2897 removed

comment:12 follow-up: ↓ 14 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from 4.8.6 to 4.8.7

comment:13 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
  • Blocking 1686 removed

comment:14 in reply to: ↑ 12 Changed 7 years ago by birdie

  • Status changed from closed to reopened
  • Resolution fixed deleted

Replying to andrew_b:

Applied as part of #2897: [5738b8d8638f89d04df6b6956ee9d93903c69197].

435	 	regex/i/\.(wav|snd|voc|au|smp|aiff|snd|m4a)$ 
 	435	regex/i/\.(wav|snd|voc|au|smp|aiff|snd|m4a|ape|aac|wvm4a)$ 

Obviously there's a typo here: "wvm4a" should be "wv" (as m4a is still present)

comment:15 follow-up: ↓ 16 Changed 7 years ago by andrew_b

  • Blocked By 2888 added

comment:16 in reply to: ↑ 15 ; follow-up: ↓ 17 Changed 7 years ago by birdie

Replying to andrew_b:

There's a typo in release notes:

"Enter into symlink to commpressed patch shows empty patch 1"

comment:17 in reply to: ↑ 16 Changed 7 years ago by andrew_b

Thanks! A lot of typos were fixed.

comment:18 Changed 7 years ago by andrew_b

  • Blocked By 2888 removed

comment:19 Changed 7 years ago by andrew_b

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in master branch.

Note: See TracTickets for help on using tickets.