Ticket #2763 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Last word of help links not clickable

Reported by: egmont Owned by: angel_il
Priority: major Milestone: 4.8.3
Component: mc-core Version: 4.8.1.1
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

The last word of hyperlinks in the interactive help don't act on mouse clicks. This also implies that one-word links can't be clicked at all.

E.g. on the opening screen of the F1 help, the "Enter", "contents", "authors", "WARRANTY" links can't be clicked with the mouse. The last link, "GNU General Public License" is only followed if you click somewhere on "Gnu General Public " (including the trailing space), but not on "License".

Under "contents" there are many multi-word links, it's easy to verify that it's always the last word that doesn't work.

(My wild guess, without looking at the source, is an off-by-one bug somewhere in the code that wraps the text into lines.)

Attachments

mc-4.8.1.1-help-link-click.patch (665 bytes) - added by egmont 7 years ago.

Change History

Changed 7 years ago by egmont

comment:1 Changed 7 years ago by egmont

Patch attached.

First the last word should be printed using help_print_word(), and then should the end of the click area be registered using end_link_area().

I think they could both go to CHAR_LINK_POINTER or both to CHAR_LINK_END, it probably wouldn't make a difference.

comment:2 Changed 7 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il
  • Votes for changeset set to angel_il
  • Branch state changed from no branch to on review

branch: 2763_help_dialog_fix
parent: master

Please review

comment:3 Changed 7 years ago by andrew_b

  • Keywords stable-candidate added
  • Votes for changeset changed from angel_il to angel_il andrew_b
  • Branch state changed from on review to approved
  • Milestone changed from Future Releases to 4.8.3

comment:4 Changed 7 years ago by angel_il

  • Votes for changeset changed from angel_il andrew_b to committed-master
  • Branch state changed from approved to merged

comment:5 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 7 years ago by slavazanko

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.8.1-stable: [d7e6a68d9e72214350d93d9914359211489da6fe].

Last edited 7 years ago by andrew_b (previous) (diff)
Note: See TracTickets for help on using tickets.