Ticket #2753 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

hotlist: broken newly added entries if old-style path is present

Reported by: slavazanko Owned by: slavazanko
Priority: major Milestone: 4.8.3
Component: mc-core Version: 4.8.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description (last modified by slavazanko) (diff)

Steps to reproduce:

  • try to replace your ~/.config/mc/hotlist by:
    ENTRY "old-style-url" URL "/#sh:root@myserver.ru:C/var/www/site.ru/htdocs"
    
  • run mc, press ctrl+\ (call hotlist)
  • add current directory to hotlist
  • see content of your ~/.config/mc/hotlist

expected result: should be new entry with path to current directory

actual result: few random bytes here (looks like as data pointer)

Change History

comment:1 Changed 8 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • Milestone changed from Future Releases to 4.8.3

comment:2 Changed 8 years ago by slavazanko

  • Description modified (diff)
  • Summary changed from hotlist: broken new entries if old-style path is present to hotlist: broken newly added entries if old-style path is present

comment:3 Changed 8 years ago by slavazanko

  • Branch state changed from no branch to on review

Created branch 2753_broken_hotlist

Review, please.

comment:4 Changed 8 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 8 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • Version changed from master to 4.8.2
  • Branch state changed from on review to approved

comment:6 Changed 8 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to committed-master
  • Blocked By 2695 added
  • Branch state changed from approved to merged
  • Keywords stable-candidate added
  • Resolution set to fixed

Merged to master:

git log --pretty=oneline 5b84f73..408ba2a

comment:7 Changed 8 years ago by NMorozov

I have deleted hotlist and just created a new first entry (adding my home directory)
got this trash

hotlist

ENTRY "/home/nmorozov" URL ".wY.e/nmorozov"

As I understand all neww added entrys are broken

Last edited 8 years ago by NMorozov (previous) (diff)

comment:8 Changed 8 years ago by slavazanko

Yes, all newly added entries have broken before fix. But current 'master' branch is free from this bug.

comment:9 Changed 8 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
  • Blocked By 2695 removed

Picked to stable as part of #2695

Note: See TracTickets for help on using tickets.