Ticket #2747 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

directory hotlist failing when entries use ~/$HOME

Reported by: johslarsen Owned by: andrew_b
Priority: minor Milestone: 4.8.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

Reproduce bug

  1. (Optional) Create a hotlist with an entry using ~ or $HOME
    echo 'ENTRY "HOME" URL "~"' > ~/.mc/hotlist
    
  2. Start mc
  3. Open directory hotlist
  4. Change to any entry using ~ or $HOME (named HOME if using example from 1.)

Expected output

The directory in the selected panel changes to the URL of the entry (your home directory if using example from 1.)

Result

Error box:

Cannot chdir to "CURRENTDIR/URL_OF_ENTRY"
No such file or directory (2)

First bad commit

Result from using git bisect:

32a9f8257d0417abb4083c801215b4d48ae4933a

MC Version

$ LC_MESSAGES=C src/mc -V
sfs_init(): Warning: file /usr/local/etc/mc/sfs.ini not found
Warning: cannot open /usr/local/libexec/mc/extfs.d directory
GNU Midnight Commander 4.8.1-138-ga742521
Built with GLib 2.30.2
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;
$ uname -a
Linux blo 3.2.9-1-ARCH #1 SMP PREEMPT Thu Mar 1 09:31:13 CET 2012 x86_64 AMD Phenom(tm) II X6 1055T Processor AuthenticAMD GNU/Linux

Change History

comment:1 Changed 8 years ago by andrew_b

  • Keywords hotlist tilde ~ home removed
  • Status changed from new to closed
  • Version master deleted
  • Resolution set to duplicate
  • Milestone Future Releases deleted

What about #2425?

Version 0, edited 8 years ago by andrew_b (next)

comment:2 Changed 8 years ago by andrew_b

  • Status changed from closed to reopened
  • Version set to master
  • Resolution duplicate deleted
  • Milestone set to Future Releases

Sorry. Tilde is handled incorrectly.

comment:3 Changed 8 years ago by andrew_b

  • Status changed from reopened to accepted
  • Owner set to andrew_b

comment:4 Changed 8 years ago by johslarsen

$HOME works when prefixing with "/", so I got myself a workaround

Thank you for the help.

comment:5 Changed 8 years ago by andrew_b

  • Keywords stable-candidate added
  • Branch state changed from no branch to on review

Branch: 2747_hotlist_load_fixups (parent: master).
Initial changeset:691d66645e2ebf1e5757b6549c1435d7d2a60ad4

comment:6 Changed 8 years ago by slavazanko

  • Blocked By 2118 added

comment:7 Changed 8 years ago by slavazanko

  • Blocked By 2118 removed

Ops, sorry, errorneus blockedBy

comment:8 Changed 8 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:9 Changed 8 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:10 Changed 8 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master.
changeset:61ee9cef43b90d57d62eb3f18dd01ba4eaf80cdc

git log --pretty=oneline a742521..61ee9ce

comment:11 Changed 8 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
  • Milestone changed from Future Releases to 4.8.2

Cherry-picked to 4.8.1-stable.
Initial changeset:b534ce73b7538fa5aeb2b4a57b3ae324afd47895

git log --pretty=oneline dec6011..62b6023
Note: See TracTickets for help on using tickets.