Ticket #2733 (assigned enhancement)

Opened 5 years ago

Last modified 8 months ago

The file view/edit history.

Reported by: angel_il Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc: fsefrna@…
Blocked By: Blocking:
Branch state: on rework Votes for changeset:

Description

The file view history must shows the list of files that has recently viewed or edited.

part of #280

simple_file_edit_history_list.patch Download (1.5 KB) https://www.midnight-commander.org/raw-attachment/ticket/280/simple_file_edit_history_list.patch - added by >filipsef 6 months ago.

proof-of-concept of a simple file edit history list

Attachments

2733-file-edit-history.patch (7.2 KB) - added by filipsef 15 months ago.
updated patch working with master on 05-13-2016

Change History

comment:1 Changed 5 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:2 Changed 5 years ago by angel_il

  • Branch state changed from no branch to on review

branch: 2733_edit_view_history

please review

comment:3 Changed 5 years ago by angel_il

  • Cc fsefrna@… added

comment:4 follow-ups: ↓ 6 ↓ 7 Changed 5 years ago by filipsef

I've been using the function for a couple of months now and I think it's more usable if we select the file (try_to_select) instead of editing it directly (do_edit_at_line) because

  • editing the selected file is just one more keypress (F4)
  • user may want to do other operations with the file (e.g. view it instead of editing) or with a different file in the same directory
  • it can be then used as a 'history of visited directories where a file was edited' which is useful when history of visited directories (Alt-Shift-H) gets bloated because of lots of directory changes

Anyway, the best would be if F4 ran the editor directly and Enter selected it. Also an inline search/filter similar to Ctrl-S in panel would be nice but all this would require to use something else than history_show.

I can work on it if there is a good chance that it will be accepted. Is there ?

comment:5 Changed 5 years ago by angel_il

  • Milestone changed from 4.8.2 to Future Releases

comment:6 in reply to: ↑ 4 Changed 5 years ago by angel_il

I can work on it if there is a good chance that it will be accepted. Is there ?

are you have github account? can you fork this branch?

comment:7 in reply to: ↑ 4 Changed 5 years ago by angel_il

Replying to filipsef:

I've been using the function for a couple of months now and I think it's more usable if we select the file

I can work on it if there is a good chance that it will be accepted. Is there ?

please try new version..

enter - goto to file
f3 - open in viewer
f4 - open into editor

comment:8 Changed 5 years ago by filipsef

It looks fine, thanks a lot.

comment:9 Changed 5 years ago by angel_il

maybe you wish rework the parser? little more :)
parser has follow trouble - files with space in names parsed incorrect.

comment:10 Changed 5 years ago by slavazanko

  • Branch state changed from on review to on rework

comment:11 Changed 15 months ago by filipsef

I've been using this feature for years and I'd like to get it in.
I'm attaching an updated patch working with the current master.

Changed 15 months ago by filipsef

updated patch working with master on 05-13-2016

comment:12 Changed 8 months ago by andrew_b

  • Owner angel_il deleted
  • Status changed from accepted to assigned
Note: See TracTickets for help on using tickets.