[PATCH] Allow using SI-based size prefixes

[bilbo]

I have created a patch that allows switching between old (default) 1024 based "binary" prefixes and SI (1000 based) size prefixes when displaying file sizes. I personally prefer 1000-based prefixes, so this patch gives user a choice to use them too if they want.

[bilbo]

Patch to allow using SI units for byte size prefixes

[slyfox]

Look here:

279 /*
280 * If true, SI units (1000 based) will be used for
281 * larger units (kilobyte, megabyte, ...).
282 * If false binary units (1024 based) will be used.
283 */
284 bool kilobyte_si = 0;

and here:

393 if (kilobyte_si) {
394 size = (size + 512) >> 10;
395 } else {
396 size = (size + 500) / 1000;
397 }

Looks like condition shoud be inverted.

The rest looks fine
(except, maybe, already been there nongettextized "M" and "K" duplication).

[bilbo]

fixed patch, the condition is now correct

[bilbo]

Oops, I overlooked this. I have attached a fixed patch.

What do you mean by 'nongettextized "M" and "K" duplication' ?

[slyfox]

What do you mean by 'nongettextized "M" and "K" duplication' ?

Ideally,

{"", "k", "m", "g", "t", "p", "e", "z", "y", NULL};

could be internationalized via gettext (in far future :])

and this looks like identifier duplication:

xtra = kilobyte_si?"k":"K";

...

xtra = kilobyte_si?"m":"M";

can be changed to suffix[1,2]/suffix_ic[1,2] (with little code restructurements: move suffix* definitions upper). But will it be more readable?

Tried to apply patch and didn't find this config option in menus. Is it intended for use in '~/.mc/ini' file only?

[metux]

Added your patch to the 268_si_units branch @ ​git://git.metux.de/free-mc.git/

Please check back and let me know if evrything's fine for going to master.

[bilbo]

Updated to current git master

[bilbo]

Seems the repository at ​git://git.metux.de/free-mc.git/ differ a lot to ​git://midnight-commander.org/git/mc.git - I am not sure which one is outdated though ....

I was unable to compile from the branch from ​git://git.metux.de/free-mc.git/ due to missing libraries, though I have updated the patch for current head from ​git://midnight-commander.org/git/mc.git and it works fine.

[slavazanko]

we don't support ​git://git.metux.de/free-mc.git/ repro, this repro was created by Enrico Weigelt (aka Metux)some time ago, where we drop from sourses tree support of mhl.

I don't know, is this repro actual for now.

Just use our repro, please :)

[slavazanko]

attachment kilobyte-git.3.patch added

And big thanks for patch - we will review it in near time.

[bilbo]

Update to current master

[bilbo]

Updated patch to current master - no actual changes, but removed parts of the patch that changed the changelog, which is no longer present in the source tree.

[bilbo]

Added configuration for this option into dialog

[bilbo]

I have reworked the patch:

The definition of kilobyte_si variable is moved to dir.c where it seems to be more logical along with variables like show_dot_files and show_backup_files

I've added possibility to configure this setting in dialog (Option -> Configuration -> Panel options -> SI size prefixes)

As a result of this change, the section in .mc/ini file where this setting is stored changed from [Misc] to [Midnight-Commander]

You can now toggle this settings in runtime, so you no longer need to manually alter the .mc/ini file.

Please review the patch with and consider it for inclusion in master.

[angel_il]

look good, my vote here

[angel_il]

branch: 268_si_based_size (parent: master)

[angel_il]

changeset: b97bd040200438585efcd96d64c54ca7403b8e40

[andrew_b]

changeset:190c66e0e09364db3713c560eccfbf25fcf229b7

Changed option name in 'Configuration options' dialog.
Moved description to proper section in man page.
Added russian translation.

[angel_il]

Fixed: 30334296455fc24f102fb4473c99f66e04d85ebf