Ticket #2672 (assigned enhancement)

Opened 8 years ago

Last modified 4 years ago

[PATCH] Numbered listboxes and directory hotlist

Reported by: vakorol Owned by:
Priority: minor Milestone: Future Releases
Component: mc-core Version: 4.8.0
Keywords: hotlist, listbox, hotkeys Cc: mooffie@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

I think it would be convenient to display numbers for the hotkeys in directory hotlist and in listboxes in general.
Attached is a patch which adds a new property "num_type" to WListbox struct and a new enum type "listbox_numbered_t" for it. Available options for listbox->num_type are: UNNUMBERED (default), NUMBERED (number all items), NUMBERED_HOTKEYS (number the first ten items 0..9).
The patch also changes the directory hotlist to NUMBERED_HOTKEYS.
screenshot attached.

Attachments

mc-listbox_vk111116.patch.JPG (93.1 KB) - added by vakorol 8 years ago.
screenshot of numbered directory hotlist
2672_numbered_listbox.diff (4.0 KB) - added by angel_il 8 years ago.
2672_numbered_listbox.diff
mc-4.8.0-listbox_vk111116.patch (4.1 KB) - added by vakorol 8 years ago.
numbered listbox patch

Change History

Changed 8 years ago by vakorol

screenshot of numbered directory hotlist

comment:1 Changed 8 years ago by vakorol

  • Owner set to vakorol
  • Status changed from new to assigned

comment:2 Changed 8 years ago by vakorol

  • Owner vakorol deleted

comment:3 Changed 8 years ago by vakorol

  • Branch state changed from no branch to on review

comment:4 Changed 8 years ago by vakorol

  • Summary changed from Numbered listboxes and directory hotlist to [with patch] Numbered listboxes and directory hotlist

comment:5 Changed 8 years ago by vakorol

  • Summary changed from [with patch] Numbered listboxes and directory hotlist to [PATCH] Numbered listboxes and directory hotlist

comment:6 follow-up: ↓ 7 Changed 8 years ago by andrew_b

  • Branch state changed from on review to no branch

Please don't change branch state if you don't know exactly what that mean.

comment:7 in reply to: ↑ 6 Changed 8 years ago by vakorol

Replying to andrew_b:

Please don't change branch state if you don't know exactly what that mean.

ok, sorry

comment:8 follow-ups: ↓ 9 ↓ 10 Changed 8 years ago by andrew_b

Please, create unified patches (diff -u).

Partially, listbox hotkeys are implemented in "Choose codepage" dialog (see select_charset() function for details). I agree, it should be implemented in listbox widget to avoid code duplication in the future.

Then, why you limit hotkeys in 0..9 range? What about letters [a-zA-Z] and even other symbols as in user menu?

comment:9 in reply to: ↑ 8 Changed 8 years ago by vakorol

Replying to andrew_b:

Please, create unified patches (diff -u).

Partially, listbox hotkeys are implemented in "Choose codepage" dialog (see select_charset() function for details). I agree, it should be implemented in listbox widget to avoid code duplication in the future.

Then, why you limit hotkeys in 0..9 range? What about letters [a-zA-Z] and even other symbols as in user menu?

I thought about that. Letters [a-zA-Z] would interfere with button hotkeys in dialogs. I'll think how avoid this.

Changed 8 years ago by angel_il

2672_numbered_listbox.diff

Changed 8 years ago by vakorol

numbered listbox patch

comment:10 in reply to: ↑ 8 Changed 8 years ago by vakorol

Updated the patch.

comment:11 Changed 4 years ago by mooffie

  • Cc mooffie@… added
Note: See TracTickets for help on using tickets.