Search finds bold/underlined strings twice

[egmont]

If you search (F7) in a manual page in mc's built-in viewer, matches whose first character is logically bold or underlined (physically yellow or red) are found twice. That is, pressing Shift+F7 or 'n' first doesn't do anything, only goes to the next match when pressed again.

The reason seems to be that when you search from the first byte of that special string (which is the letter or the underscore before the backspace) then it matches first. Later, when you search from the repeated letter after the backspace (that is, byte offset increased by two) then it matches again.

An idea for a solution which I'm not sure about: the first match can easily be skipped: if haystack's second character is a backspace, then just simply pretend it doesn't match. This way only the second match is reported. I can't see at the moment whether it would have any effect on highlighting (e.g. the first character of the match wouldn't be shown as bold/underlined). It would be cleaner to report the first match and skip the second, but I can't see how that could easily be done.

I also cannot see at the moment why backwards search finds everything only once, and not twice for bold text.

[styx]

new beheviour with new search engine

get test file from #265.

1. open file
2. make 2 serches of 'ab' forward
3. then try backward

[slavazanko]

see branch 265_finds_bold_underline_in_view
Branch need to complete work - not all funds correctly highlight.

BTW, #264 very coherent to this ticket...

[slavazanko]

Well, review please 265_finds_bold_underline_in_view

Bug for this ticket fully closed.

[styx]

it is much better for now, but ...
try to find 'ab' pattern in file from 264

[styx]

and also try to use backward searching for 'ab' pattern
test file is also in: #264

[egmont]

Please also see #266 for a long but hopefully useful rant about how hugely conceptually broken the current backwards search is (in 4.6.2 - not sure about dev).

[slavazanko]

Okay, I think branch 265_finds_bold_underline_in_view now reading for review.

Error from #264 fixed, twice-search behavior from this ticket fixed and no raise search result on any 'red text' by '_' search keyword.

Review please.

[andrew_b]

Works correct. My vote here.

[slavazanko]

changeset:abf38df5e0678ce2f577aaa5c77dbda3da90757d

[slavazanko]

(In #375) Fixed in #265

[slavazanko]

(In #2294) Created branch 2294_viewer_search_offset

Initial changeset:899bcae078f2dfc82182b05268c4c691a467220b

Review, please.

I think it's better to have duplicate matches in a rare use case rather than missing some matches in a more common use case.

You right, after resolve this issue #265 will be reopened.

[slavazanko]

(In #2294) Merge changeset:becd744bb664ea0b7c6ffeef99113ea851cdc695

For getting list of commits type:

git log --pretty=oneline 906f688..3ad5f51

[slavazanko]

(In #1629) Merge changeset:d7fd84507c063adb79b02b544d07203b73518831

Commits:

git log --pretty=oneline 7d52669..79660a7

[slavazanko]

Created branch 265_viewer_nroffed_finds_twice

initial changeset:a20c7a648b1569a388794913a71039de99f33c60

review, please

[slavazanko]

merge changeset:1dc4c30eb9811b0a1e4339fb7ea4af516e15680f

commints in branch:

git log --pretty=oneline c119682..b3e9a75

[slavazanko]

Cherry-picked in stable:

git log --pretty=oneline a1cc8f37e5..ec441ece0f