Ticket #2625 (closed defect: fixed)

Opened 8 years ago

Last modified 3 years ago

[patch ready] mc does not preserve file mtime when copying over ssh

Reported by: sergem Owned by: slavazanko
Priority: major Milestone: 4.8
Component: mc-vfs Version: 4.7.5.5
Keywords: Cc: gotar@…
Blocked By: Blocking: #51
Branch state: merged Votes for changeset: commited-master commited-stable

Description

mc does not preserve file mtime when copying over ssh

Attached patch should fix this problem.

Attachments

mc-4.7.5.5-sshutime.patch (5.1 KB) - added by sergem 8 years ago.
mc-4.7.5.5-sshutime-perl.patch (5.5 KB) - added by sergem 8 years ago.
Same patch, but using perl utime and fallback to touch if no perl found

Change History

Changed 8 years ago by sergem

Changed 8 years ago by sergem

Same patch, but using perl utime and fallback to touch if no perl found

comment:1 Changed 8 years ago by gotar

  • Cc gotar@… added

comment:2 Changed 8 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:3 Changed 8 years ago by slavazanko

  • Keywords stable-candidate added
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8

Created two branches:

Review, please.

Last edited 8 years ago by slavazanko (previous) (diff)

comment:4 Changed 8 years ago by andrew_b

  • Blocking 51 added

comment:5 Changed 8 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 8 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il amdrew_b
  • Branch state changed from on review to approved

comment:7 Changed 8 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il amdrew_b to commited-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master:

git log --pretty=oneline 6f13867..ccb6de9
Version 0, edited 8 years ago by slavazanko (next)

comment:8 Changed 8 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Merged to stable:

git log --pretty=oneline ebb5c99..729aaed

comment:9 Changed 4 years ago by ag

What are the reasons to add and prefer perl over touch? The nanosecond precision [1] would work with touch, but since I can't find "perl utimensat" I'm not sure it would work so easy with perl (without additional modules).

[1] https://www.midnight-commander.org/ticket/3575

comment:10 Changed 4 years ago by zaytsev

I think that the original motivation for preferring Perl in all cases for FISH if it is available at all was compatibility. We have constantly had problems with FISH scripts not working properly in various settings due to non-POSIXness of available shells and tools, and Perl turned out to be a) very compatible and b) generally faster.

I'm not sure that it's worth reversing the defaults here...

Note: See TracTickets for help on using tickets.