Ticket #262 (closed task: fixed)
remove obsolete own putenv() implementation
Reported by: | metux | Owned by: | metux |
---|---|---|---|
Priority: | major | Milestone: | 4.7.1 |
Component: | mc-core | Version: | 4.7.0-pre4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: | committed-master committed-stable |
Description (last modified by metux) (diff)
remove obsolete own putenv() implementation
branch:262_remove_putenv
Change History
comment:1 Changed 16 years ago by metux
- Keywords review added
- Status changed from new to accepted
- Description modified (diff)
comment:2 Changed 16 years ago by metux
- Status changed from accepted to assigned
- Description modified (diff)
comment:3 Changed 16 years ago by slavazanko
- Keywords rework added; review removed
- Milestone changed from 4.7 to future releases
I think, need to rework to usage g_getenv, g_putenv functions
comment:4 Changed 15 years ago by metux
- Status changed from assigned to accepted
- Description modified (diff)
- Version changed from 4.6.2 to 4.7.0-pre4
- Milestone changed from Future Releases to 4.7.1
- Keywords rework removed
- severity set to on review
Rebased to current master
comment:5 Changed 15 years ago by slavazanko
- Type changed from defect to task
Rebased for adding ticket number in first commit in branch.
Initial changeset:c9c707fea68cfd56f7a910624c2e954ba7f3aa10
Also, added commit:
- d07596c3a6e5e98e305ac4947e2c5ccf53cf5d72:Use of g_setenv() function instread of setenv().
Don't think that g_setenv() is just a wrapper for setenv(). For more info see glib.git/glib/gutils.c:746
comment:6 Changed 15 years ago by slavazanko
Fix changeset:
- 8be68727c883bd585039257f2c22293cf6c2fe26: change '1' to 'TRUE' in function call
Don't forgot about rebase this commit before merge in 'master' branch.
comment:7 Changed 15 years ago by metux
oh, it *is* a wrapper for setenv(), paired with an own implementation for non-posix-compliant systems.
which target has no setenv() ?
comment:8 Changed 15 years ago by metux
- Description modified (diff)
cleaned up and rebased, please review!
comment:10 Changed 15 years ago by metux
nobody who likes to review that ancient patch ? ;-o
comment:11 Changed 15 years ago by slavazanko
Why you don't review my last patch into branch? ;-o
NB! We vote by last patch in branch...
comment:12 Changed 15 years ago by angel_il
- Votes for changeset changed from andrew_b to slavazanko andrew_b angel_il
- severity changed from on review to approved
please squash last commit before merges.
comment:13 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko andrew_b angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
changeset:d26be9da5f17d0062c968e82b70b09bd3f72b304
comment:14 Changed 15 years ago by andrew_b
- Status changed from testing to closed
- Votes for changeset changed from commited-master to commited-master commited-stable
changeset:93e347c0fc607c7dc0c4272b948b578db253bc76 in stable branch