Ticket #2614 (closed defect: fixed)
Editor word completion should ignore the current word
| Reported by: | ply | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.1 |
| Component: | mcedit | Version: | 4.8.0-pre2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master committed-stable |
Description
Currently the completion considers the word the cursor is on as a possible completion, but this is quite annoying if the cursor is inside the word. Such completion effectively inserts the rest of the word one more time, so CamelCase becomes CamelCaseCase. If this is the only match, it completes automatically, which is even worse. The current word shouldn't be used for completion.
See patch.
Attachments
Change History
comment:1 Changed 13 years ago by slavazanko
- Status changed from new to accepted
- Owner set to slavazanko
- Milestone changed from Future Releases to 4.8
comment:2 Changed 13 years ago by slavazanko
- Keywords stable-candidate added
- Branch state changed from no branch to on review
Created branch 2614_word_completion
Initial changeset:5b3715e3b47155cd3056caa204c83f5d1d9fc8aa
Review, please.
comment:3 Changed 13 years ago by andrew_b
Well, patch does not fully fix the problem.
Example. Open configure.ac. Find lines 16 and 17:
16 AC_SUBST(LIBMC_VERSION)
17 AC_SUBST(LIBMC_RELEASE)
Note: there are many 'AC_SUBST' words in the file.
Move cursor to the B letter in AC_SUBST word in some line. Press esc-tab. You get AC_SUBSTBST.
comment:5 Changed 13 years ago by andrew_b
- Votes for changeset set to andrew_b
- Component changed from mc-core to mcedit
- Milestone changed from 4.8 to 4.8.0
comment:7 Changed 13 years ago by slavazanko
- Votes for changeset andrew_b deleted
Branch rebased to 4.7.5-stable
Also, new commit was added.
Review again, please.
comment:9 Changed 13 years ago by angel_il
- Votes for changeset changed from andrew_b to andrew_b angel_il
- Branch state changed from on review to approved
comment:10 Changed 13 years ago by slavazanko
- Keywords stable-candidate removed
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b angel_il to committed-master committed-stable
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to stable:
git log --pretty=oneline d33ae78..056200e
- 056200ee42f175c098c0ff96946881e6e6c6a934 Fixed searching the start of word
- 0b4fb9bd992c6bb78f3aa86a67aa2879e2b64c3d Code optimization: avoid lot of calls for alloc/free memory in cycle.
- 2605034e552ad42969d2c5db7c1d8a6722f444f2 Current word under cursor doesn't included in completion list, if same word already ex
- 206a59a358318b4a4fc387b5dcd4af1015c0aabd Ticket #2614: Editor word completion should ignore the current word
Rebased and merged to master:
git log --pretty=oneline 1f24672..87e6589
