Ticket #259 (closed enhancement: fixed)

Opened 11 years ago

Last modified 10 years ago

Please focus UTF-8 patch only on UTF-8, nothing else

Reported by: egmont Owned by: winnie
Priority: minor Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

The "unofficial" UTF-8 does not only make mc work in UTF-8 environment; it also changes its behavior in certain other ways. So far I've found two differences, there may be more:

  • It changes the order the Up, Down and Tab keys go through the items of the Copy and Move (F5, F6) dialogs.
  • It adds scrollbar to the panels.

I'm not an mc developer to suggest good practices, but I think the UTF-8 patch is already too large and complicated and must be a pain to maintain. Adding other, irrelevant changes here and making it include even the kitchen sink sure does not help.

So please consider keeping the UTF-8 patch serve no more than one goal: to make mc work seamlessly after someone's switched his system from ISO-whatever to UTF-8. Some users might also log in to multiple systems, maybe they don't ever use any accented letters, still, the same mc version would behave differently for them, just because one distribution chose to apply the UTF-8 patch, the other didn't. It shouldn't be so.

More particularly:

  • If the new Tab order for the Copy/Move? dialog is considered to be a bugfix (which I'd be glad to see) then please merge it into mainstream mc. If not, then it shouldn't be in the UTF-8 patch either. (Oh, and see ticket #254 BTW.)
  • If the scrollbar is something that you like (even though I personally hate it), it should go into main mc (maybe with less cool characters). If it's in mainstream mc, I'd be willing to accept it and get used to the new look. However, I really don't like that I need to have the scrollbar just because I need UTF-8. Maybe it could be a separate additional patch (that might depend on UTF-8 if it's technically required). But I don't think it should be part of the UTF-8 patch.

Thanks!

Change History

comment:1 Changed 11 years ago by winnie

  • Owner set to winnie
  • Status changed from new to accepted
  • Milestone changed from 4.6.2.1 to UTF8 Support

Thanks for your report.. this is certainly something which should be fixed.. but this also don't belong into the 4.6.2.1 milestone.

comment:2 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed

Utf-8 support now in master. New search engine in master too, because older searches in mc don't support multicharsets searches, but I hope that the new search engine you'll like :)

In other cases in master now utf-8 and only utf-8

comment:3 Changed 10 years ago by slavazanko

  • Milestone changed from UTF8 Support to 4.7

comment:4 Changed 10 years ago by styx

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.