Ticket #2538 (closed defect: fixed)
Unused result of str_term_width1()
Reported by: | pavlinux | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 4.8.4 |
Component: | mcview | Version: | master |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: |
Description
Just yet not used (or already) :)
Attachments
Change History
Changed 14 years ago by pavlinux
- Attachment unused_file_label_width.patch added
Too big buffer size
comment:2 Changed 12 years ago by andrew_b
- Priority changed from major to minor
- Branch state set to no branch
- Milestone changed from 4.8 to 4.8.4
comment:4 Changed 12 years ago by andrew_b
- Status changed from new to closed
- Resolution set to fixed
- Blocked By 2845, 2846 removed
- Branch state changed from no branch to merged
Fixed in master: [2c4562d75903ef618dbebed4c583c7068b3f248d].
Fixed in 4.8.1-stable: [04ab8ef2b76e3c0718ee7e23b011f0e376911857].
Note: See
TracTickets for help on using
tickets.
Or, may be, instead of:
if (width > 40)
must be
if ( file_label_width > 40)
?
And more, buffer will never be 64 bytes, no more 5 chars.