Ticket #2530 (reopened enhancement)

Opened 7 years ago

Last modified 3 years ago

Don't reset selection on mouse clicks, but only on mouse drags

Reported by: vitalif Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: 4.7.5
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

By now, mc resets selection on every mouse click. That's very inconvenient as selecting with mouse is usually needed when the you don't want to navigate far away with key presses, and you'll probably not want to navigate back with keys again. But you can't navigate back with mouse as it will reset the selection you've just made.

I think mc must reset selection only if the user starts new one, i.e. drags the mouse. See attached patch please :)


BTW, there was a change in Ctrl-Ins behaviour somewhere between 4.7 and 4.8 - in 4.7 Ctrl-Ins resetted the selection, but now it doesn't. I think it was more convenient when it resetted the selection. Are there any principal arguments? Maybe the behaviour could be restored to original, or selected with an option?

Attachments

mc-git20110403-dont-reset-selection-on-gpm-click.diff (1.8 KB) - added by vitalif 7 years ago.
Reset selection only on GPM_DRAG
mc-4.8.0-reset-after-store.diff (358 bytes) - added by vitalif 6 years ago.
Reset selection after copying it to the clipboard patch

Change History

Changed 7 years ago by vitalif

Reset selection only on GPM_DRAG

comment:1 in reply to: ↑ description Changed 7 years ago by andrew_b

Replying to vitalif:

mc resets selection on every mouse click.

And what other editors don't do that?

comment:2 Changed 7 years ago by vitalif

Hmm... :) this is an argument.

The patch is probably only useful when you use F3 F5 etc... select copy move commands and not clipboard. And yes, I'm really using it :)) But, I think the patch does not add any inconvenience?

comment:3 Changed 7 years ago by victor-homyakov

Other text editors (FAR editor, for example) have explicit option ("Persistent blocks"). Persistent block isn't deselected on cursor keys and mouse clicks, while not persistent block is deselected. This behavior is internally consistent.
MC editor keeps selection on cursor keys, but clears selection on mouse clicks - this is inconsistent, I think.

comment:4 Changed 7 years ago by angel_il

  • Status changed from new to closed
  • Resolution set to wontfix
  • Branch state set to no branch

comment:5 Changed 7 years ago by gotar

  • Cc gotar@… added

comment:6 Changed 6 years ago by vitalif

  • Status changed from closed to reopened
  • Resolution wontfix deleted

Why wontfix?

Changed 6 years ago by vitalif

Reset selection after copying it to the clipboard patch

comment:7 Changed 5 years ago by sknaumov

I've come up to the same patch (reset-after-store) for 4.8.7 and 4.8.8 (what a pity I haven't seen this ticket before). I can confirm that this patch works as it should and I patched my mc about 6 mounths ago without any issues. But this patch drops selection after Ctrl+Ins even if editor_persistent_selections=1. I don't know whether it is a desired behavior - I always use editor_persistent_selections=0.

Last edited 5 years ago by sknaumov (previous) (diff)

comment:8 Changed 3 years ago by andrew_b

  • Milestone changed from 4.8 to Future Releases
Note: See TracTickets for help on using tickets.