Ticket #2525 (assigned enhancement)

Opened 8 years ago

Last modified 2 years ago

editor: add option to show EOL

Reported by: jengelh Owned by:
Priority: minor Milestone: Future Releases
Component: mcedit Version: 4.7.5
Keywords: Cc: mooffie@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

This is my EOL patch forward-ported from http://midnight-commander.org/ticket/113

The following changes since commit 78019b896ba0e59ba886ecf500747cbe77dbc7cb:

Merge branch '2520_ctrlg_closes_panels' (2011-03-30 16:18:45 +0400)

are available in the git repository at:

git://dev.medozas.de/mc 2525_highlight_eol

Jan Engelhardt (1):

editor: add option to show EOL

src/editor/edit.h | 1 +
src/editor/editdraw.c | 8 +++++++-
src/editor/editoptions.c | 24 +++++++++++++-----------
src/setup.c | 1 +
4 files changed, 22 insertions(+), 12 deletions(-)

Attachments

2525.diff (5.7 KB) - added by jengelh 8 years ago.

Change History

Changed 8 years ago by jengelh

comment:1 Changed 8 years ago by andrew_b

  • Priority changed from major to minor

comment:2 Changed 8 years ago by angel_il

2 Jan:
please attach patches made as follow:

 $ git format-patch HEAD^ (if need upload 1 current commit)
 $ git format-patch HEAD~3 (if need upload 3 commits)
 $ git format-patch origin/master(if need upload all commits from 'master')

and thank you for the patches

comment:3 Changed 8 years ago by andrew_b

Patch should be updated to have a nice look'n'feel in non-unicode locales. Hardcoded 0xB6 symbol is not a good way, it should be defined in skins.

comment:4 Changed 8 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il
  • Branch state set to no branch

comment:5 Changed 4 years ago by mooffie

  • Cc mooffie@… added

Editors like Mined[1] and Geresh[2] show different indicators for different types of EOLs (see screenshots).

They also indicate the very last line, if it's missing its EOL, with yet another distinguishing indicator (they happen to use the "not" character). This alone is a useful feature.

[1] http://towo.net/mined/screenshots.html
[2] http://www.typo.co.il/~mooffie/geresh/sshot02.png

comment:6 Changed 4 years ago by andrew_b

  • Milestone changed from 4.8 to Future Releases

comment:7 Changed 2 years ago by andrew_b

  • Owner angel_il deleted
  • Status changed from accepted to assigned
Note: See TracTickets for help on using tickets.