Ticket #2522 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

PanelSmartGotoParentDir action should not trigger while PanelStartSearch is active

Reported by: buenchaval Owned by: andrew_b
Priority: minor Milestone: 4.8.0-pre2
Component: mc-core Version: 4.7.5.1
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

dear commanders :)

when backspace is assigned to PanelSmartGotoParentDir?, if you try to delete
something you typed in the quick find edit widget, you are kicked up to the parent directory.

steps to reproduce:

0) cat ~/.mc.keymap

(...)
[panel]
(...)
PanelSmartGotoParentDir?=backspace
(...)

1) start mc
2) quick search for something: alt-s then type 'foo'
3) oops, i actually meant searching for 'bar', press backspace (just once is enough, but normally I would press it three times quickly)
4) the quickfind edit box should show 'fo' but what happens instead is "cd .." (one or three times :-)

thank you!

Vincent


$mc -V

GNU Midnight Commander 4.7.5.1
Built with GLib 2.26.1
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, fish
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

Change History

comment:1 Changed 8 years ago by buenchaval

  • Version changed from 4.7.5 to 4.7.5.1

comment:2 Changed 8 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:3 Changed 8 years ago by andrew_b

  • Owner changed from angel_il to andrew_b
  • Branch state set to no branch

comment:4 Changed 8 years ago by andrew_b

  • Keywords stable-candidate added
  • Branch state changed from no branch to on review
  • Milestone changed from 4.8 to 4.8.0-pre2

Created 2522_smart_backspace branch (parent: master).
changeset:7a08e8be121150b74eb3dbd980a6ee2afa679bb1

comment:5 Changed 8 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 8 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • Branch state changed from on review to approved

comment:7 Changed 8 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:8 Changed 8 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked in stable:

git log --pretty=oneline 6705843ba4d..a59cd929e6
Note: See TracTickets for help on using tickets.