Ticket #2511 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Unification of keybinding names and simplification of key rebinding

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.8.0-pre1
Component: mc-key-bindings Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

  1. There are many keybinds that mean the same action but have different names. For instance: EditHelp, ViewHelp, HelpHelp, TreeHelp, CmdHelp, DialogHelp, DiffHelp. The unique name Help should be used instead of that 7 names.

The same situation is with the most of other keybind names.

The proposition: remove prefixes (Edit, View, Help, Cmd, Panel, etc) and unify keybind names as much as possible.

  1. Currently, to rebind some keys, used must redefine the entire

keymap section where that bindings are in. New binding algorithm
should not require the redefinition of entire section in user's
keymap file. Section should contain only actually rebinded keys.

Change History

comment:1 Changed 49 years ago by angel_il

  • Blocking 2465 added

(In #2465) branch 2465_dynamically_resize_panels (parent: master)
changeset 2465_dynamically_resize_panels

please review

comment:1 Changed 8 years ago by andrew_b

  • Description modified (diff)

comment:2 Changed 8 years ago by andrew_b

  • severity changed from no branch to on review

Created 2511_simplify_keybindings branch (parent: master).
Initial changeset:9f05200d1acf96bf7b767e4714bf2dfb8965f631

comment:3 Changed 8 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:4 Changed 8 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:5 Changed 8 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:b67d0c0b92e807141913c1dbc5401b87b0dc5018

git log --pretty=oneline 7e87dd7..b67d0c0

Renamed keybinding names are describe in doc/keybind-migration.txt file in source code tree and in migration to keybindings in 4.8.x series wiki page.

comment:6 Changed 8 years ago by andrew_b

  • Blocking 2465 removed

comment:7 Changed 8 years ago by andrew_b

  • Status changed from closed to reopened
  • Votes for changeset committed-master deleted
  • severity changed from merged to no branch
  • Resolution fixed deleted
  • Version changed from 4.7.5 to master
  • Type changed from task to defect

In editor, column mark with alt-arrows keys is broken.

comment:8 Changed 8 years ago by andrew_b

  • severity changed from no branch to on review

Branch: 2511_editor_alt_arrow_mark. Parent: master.
changeset:ae07d3a9d48cf0e012c5aff9311bd304a3e6f193

comment:9 Changed 8 years ago by angel_il

  • Votes for changeset set to angel_il

comment:10 Changed 8 years ago by slyfox

  • Votes for changeset changed from angel_il to angel_il slyfox
  • severity changed from on review to approved

worksforme

comment:11 Changed 8 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from angel_il slyfox to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged
Note: See TracTickets for help on using tickets.