"Find File" should display relative paths for relative search

[curtis]

The results of a file find display whole paths, but should instead display relative path.

I'm already in /home/curtis/src/mc/mc.git. Even the left pane displays ~/src/mc/mc.git.

Example attached. It displays /home/curtis/src/mc/mc.git/src/filemanager when it should just display src/filemanager path.

[curtis]

Find File shoudn't display full paths like this

[andrew_b]

Replying to curtis:

The results of a file find display whole paths, but should instead display relative path.

Why?

Sorry, but no.

[curtis]

Replying to andrew_b:

Replying to curtis:

The results of a file find display whole paths, but should instead display relative path.

Why?

Because when searching for a relative path, prepending the full/explicit subdirs has the potential to makes the display unnecessarily long and clutters the screen.

So correction: it should display relative paths when the "Start at:" is a relative path such as "." instead of an explicit/full path.

This is a request to have old mc-like behavior back. But maybe better? :-)

For example, if the pane/focus is already in /home/curtis/src/mc and one searches in "." for files containing "CAREFUL_ALIGNMENT" then the results should be listed in:

./mc.git/lib/vfs/mc-vfs/samba/include

Not in:

/home/curtis/src/mc/mc.git/lib/vfs/mc-vfs/samba/include  

However, it one searches in "/home/curtis/src/mc" instead of "." then the latter result is appropriate.

[andrew_b]

Patches are welcome!

[gotar]

It used to work properly until f5a93bf74ca1048433b6ad687e4fd773c1b69ce3:

f5a93bf74ca1048433b6ad687e4fd773c1b69ce3 is the first bad commit
commit f5a93bf74ca1048433b6ad687e4fd773c1b69ce3
Author: Andrew Borodin <aborodin@vmail.ru>
Date:   Fri Nov 5 15:38:11 2010 +0300

    Fix of directory ignorance in file find engine.
    
    Start directory is used and displayed now as absolute path.

:040000 040000 5153de54259688d254e2d0f22fc71b4608e349c9 8960166b28f074bb917018552b8b14bca5df1a40 M      src

Now panelize results are useless in most cases. If one searches within relative location he wants relative results, that's how every other tool works and mc has worked till 4.7.4.

[gotar]

The same changeset has broken left arrow (of lynx-like motion) from panelization of directories having files only (without any subdirs). Steps to reproduce:

1. mkdir -p a/{b/c,d}
2. touch a/d/e
3. cd a/b
4. mc
5. alt-shift-/ enter l left - selection points to 'b' directory (as it should)
6. down, enter, alt-shift-/ enter l left - selection points to '..' instead of 'd'

[andrew_b]

Absolute paths was implemented to fix #2366. Till 4.7.5, the ignorance of paths was partially broken.

Support of absolute and relative paths in ignore_dir (#2275) as well as in file find engine (#2491), using each path as is, makes the algorithm too complex and intricate. The path comparision is required to deсide whether the current path will be processed or not. To compare abs and rel paths with any combination, you have to convert one of them to form of another: abs to rel or vice versa and make that each time during search process. Each such conversion requires some time and and makes find process slower. Therefore absolute paths are used to get a something like "origin of coordinates" and minimize rel to abs and abs to real conversions.

[gotar]

I remember those issues, you can find me in CC there. I don't say that anything should be changed in path comparision (search engine), only in panelization (i.e. displaying results, and comment:7 of course).

BTW does ignore_dir support wildchars?

[andrew_b]

Replying to gotar:

does ignore_dir support wildchars?

No.

[andrew_b]

Created 2491_find_file_relative_paths branch. Parent: master.
Initial changeset:db9f9138beeae40615a1189cf6d74489cf383c99

[andrew_b]

Merged to master.
changeset:a4af63e82780fa81d6c512145b3d8f614acf09e7

git log --pretty=oneline 381db14..a4af63e

[andrew_b]

Created 2491_find_file_relative_paths_stable branch (parent: 4.7.5-stable).
Initial changeset:1195900395cbb171740bf923380e81c62e064428

Review please.

[andrew_b]

Merged to 4.7.5-stable.
changeset:a733bd432121b20a304321ab5ba8e5f00e05c690

git log --pretty=oneline 109a6fb..a733bd4