Ticket #2489 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

MC_COLOR_TABLE doesn't honor the 'header' color keyword

Reported by: curtis Owned by: andrew_b
Priority: minor Milestone: 4.8.0-pre1
Component: mc-skin Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

To reproduce...

MC_COLOR_TABLE=header=black,red mc

No color change is observed.

Possibly related, the header color is also the only element that isn't changed when one overrides the core _default_ (normal) color.

MC_COLOR_TABLE=normal=black,red mc

GNU Midnight Commander 4.7.5
Built with GLib 2.24.1
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish, smbfs
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

Change History

comment:1 Changed 9 years ago by curtis

Apparently same with 'viewbold' color keyword.

comment:2 Changed 9 years ago by curtis

  • Component changed from mc-core to mc-skin

comment:3 in reply to: ↑ description Changed 9 years ago by andrew_b

Replying to curtis:

MC_COLOR_TABLE=header=black,red mc

No color change is observed.

This is fixed in #2170 (changeset:da2c82e8d3d12972a1768684e5ca1de8e573d63b).

Apparently same with 'viewbold' color keyword.

This is missed. viewselected is missed too.

comment:4 Changed 9 years ago by andrew_b

  • Owner set to andrew_b
  • Keywords stable-candidate added
  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Milestone changed from 4.8 to 4.8.0-pre1

Created 2489_viewer_old_colors branch. Parent branch is master.
changeset:c722d38664fb82ee62612257425f42c20f97c96e

comment:5 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:6 Changed 9 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:7 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 9 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.