Ticket #2478 (closed enhancement: fixed)
HARDLINK file type
Reported by: | curtis | Owned by: | slavazanko |
---|---|---|---|
Priority: | trivial | Milestone: | 4.8.0-pre1 |
Component: | mc-skin | Version: | 4.7.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: | commited-master |
Description
It doesn't work as documented, but instead seems to *wrongly* identify/highlight symlinks instead.
Of course, the LINK type also fails to detect hardlinks.
Attachments
Change History
Changed 14 years ago by curtis
- Attachment mc-hardlinkcolor.patch added
fix attached - although I'm not a programmer, so it may not be the wisest way to fix
comment:2 Changed 14 years ago by curtis
Test case is to try and add hardlink highlighting...
skin.ini:
[filehighlight]
hardlink=;cyan
filehighlight.ini:
[hardlink]
type=HARDLINK
comment:4 Changed 14 years ago by curtis
- severity changed from no branch to on review
- Milestone changed from 4.8 to 4.8.0-pre1
Please review/improve/accept this patch.
comment:5 Changed 14 years ago by andrew_b
- severity changed from on review to no branch
Please don't touch severity if you don't know exactly what that is.
comment:6 Changed 14 years ago by slavazanko
- Status changed from new to accepted
- Owner set to slavazanko
comment:7 Changed 14 years ago by slavazanko
- Priority changed from minor to trivial
- Type changed from defect to enhancement
- severity changed from no branch to on review
Created branch 2178_hardlink_highlight
Changesets:
- a3f925b0a0d98ea2a61813f2221399e547bb374d: added HARDLINK file type
- 464f9f1dfed19421baf3ea44c9be84717fb8300f: changes for respect new 'HARDLINK' highlight type.
Review, please
comment:8 Changed 14 years ago by andrew_b
- Keywords filehighlight.ini removed
- Votes for changeset set to andrew_b
comment:9 Changed 14 years ago by angel_il
- Votes for changeset changed from andrew_b to andrew_b angel_il
- severity changed from on review to approved
comment:10 Changed 14 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
git log --pretty=oneline 92061ac..2712ec2
Note: See
TracTickets for help on using
tickets.
so...
What steps will reproduce the problem?
1.
2.
3.
What is the expected output? What do you see instead?
What version of the product are you using? On what operating system?
Please provide any additional information below.