id summary reporter owner description type status priority milestone component version resolution keywords cc blockedby blocking branch_state votes 2474 [patch] fix 4.7.5 build with --disable-charset dim "Hi, I usually build mc with --disable-charset, which undefines HAVE_CHARSET in config.h. When building the latest version, 4.7.5, however, this leads to an error during linking of libedit: {{{ ... CC libedit_la-edit.lo edit.c: In function 'edit_move_forward3': edit.c:2852: warning: implicit declaration of function 'convert_to_display_c' edit.c:2852: warning: nested extern declaration of 'convert_to_display_c' edit.c:2825: warning: unused variable 'utf_ch' ... CCLD mc editor/.libs/libedit.a(libedit_la-edit.o)(.text+0xe06): In function `edit_move_forward3': : undefined reference to `convert_to_display_c' gmake[3]: *** [mc] Error 1 }}} Since convert_to_display_c is really a no-op in case HAVE_CHARSET is turned off, I guess the attached patch is the simplest way of fixing this. It also silences a warning about the unused utf_ch variable. " defect closed minor 4.8 mcedit master fixed