Ticket #2423 (new defect)

Opened 9 years ago

Last modified 4 years ago

MC doesn't jump to a destination directory upon pressing Enter on found files in the "Find Files" results panel

Reported by: birdie Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: 4.7.4
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

It works for directories but it doesn't work for files. It's very inconvenient and unintuitive.

Change History

comment:1 Changed 9 years ago by gotar

This was targeted in #2373 too. I strongly discourage using enter, because it would execute binary files and call Open command bound to file types defined. PanelCtrlNextPage = ctrl-pgdn looks appropriate for this purpose.

comment:2 Changed 9 years ago by gotar

  • Cc gotar@… added

comment:3 in reply to: ↑ description ; follow-up: ↓ 4 Changed 9 years ago by andrew_b

Replying to birdie:

It works for directories but it doesn't work for files. It's very inconvenient and unintuitive.

It's strange. It works for me in 4.7.4. Do you mean 4.7.4 exactly or a recent master?

comment:4 in reply to: ↑ 3 Changed 9 years ago by andrew_b

Ah, sorry, this is my terminology confuse. You mean panelization of file find results.

comment:5 follow-up: ↓ 6 Changed 9 years ago by birdie

I tend to think that Enter is OK for this feature - we just shouldn't run executable files or invoke associations, and firstly jump to a file destination directory. I think it's just a matter of small "if (pressed_key==Enter && we_are_in_panelization_of_file_find_results) jump_to_destination else try_to_run(file)".

I believe no one expects execution of a file when you are in "panelization of file find results" - besides Far, Total Commander and other file managers do this way.

comment:6 in reply to: ↑ 5 Changed 9 years ago by gotar

Replying to birdie:

I tend to think that Enter is OK for this feature - we just shouldn't run executable files or invoke associations, and firstly jump to a file destination directory.

Please, don't confuse users. This way current directory handling should be changed, not to directly dive into it, but first to it's parent directory.

I believe no one expects execution of a file when you are in "panelization of file find results"

If I see *binary file and tap enter, I do expect it would be executed. Why do you think people should remember if current panel presents panelization and not some VFS or real directory?

Another point - when I run such file (or start image browser on image for example) I expect panel to keep panelization. Currently it's too easy to lost this content.

besides Far, Total Commander and other file managers do this way.

I'm a bit tired of 'Far and TC' argument - if you like them, please use them.

comment:7 follow-up: ↓ 8 Changed 9 years ago by birdie

Your've made the valid points, I agree with you.

I just hope a shortcut key for a jump won't be very complicated. What about Ctrl + Enter? ;)

comment:8 in reply to: ↑ 7 Changed 9 years ago by gotar

Replying to birdie:

I just hope a shortcut key for a jump won't be very complicated. What about Ctrl + Enter? ;)

That's OK for me, however Ctrl-Enter and Alt-Enter invoke copy_prog_name() and according to help file:

"C-Enter same a Alt-Enter. May not work on remote systems and some terminals." (note typo here, please fix 'a' -> 'as')

There is something about in README.QNX and lib/tty/keyxdef.c:
#define Key_alt_enter Key_ctl_enter /* map ALT-ENTER to CTRL-ENTER */

So as long as I've got nothing against ctrl-enter in panelization (I'm using alt-enter anyway), this combination may not work and some alternative/backup key is needed. Maybe ctrl-a? alt-a does CmdCopyCurrentPathname so ctrl-a could do CmdCDPathname (not Current, because in panelization current doesn't change).

comment:9 Changed 9 years ago by birdie

Sorry for being noisy, but is Shift + Enter being used anywhere? I do think this combo must include enter, because it's the easiest to reach key and the most relevant in this situation.

comment:10 Changed 9 years ago by gotar

I've been looking for shift-enter writing previous comment - it's free and can be used, but has the same problem as ctrl-enter: won't work in some terminals and remote sessions, so some second is needed anyway. I can imagine using ctrl/shift-left/right, but they are used in command line...

comment:11 Changed 9 years ago by ossi

i often miss the functionality to jump to the containing directory and place the cursor on the target of a symlink. either in the current panel, or in the opposite one.
the parallel to the topic at hand should be obvious: these are both variations of a "follow" command. alt-f (and shif-alt-f for the other panel) seem to be still free (ctrl-a isn't, btw).

comment:12 Changed 9 years ago by birdie

  • Milestone changed from 4.7.5 to 4.8

comment:13 Changed 4 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.8 to Future Releases
Note: See TracTickets for help on using tickets.