Ticket #2404 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

MCEDIT ignores old (and documented) keys like CTRL+Z and CTRL+X

Reported by: jimklimov Owned by: andrew_b
Priority: major Milestone: 4.7.5
Component: mc-key-bindings Version: master
Keywords: Cc: zaytsev, jimklimov@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Historical Midnight Commander Editor versions (as far as I can remember - approx 10 years) have supported a number of keys for moving around the edited text file and its lines.

Specifically, long-time MC users don't think twice before pressing CTRL+X to move to next word, and CTRL+Z to move to previous word. This expected behaviour is also documented for current releases: http://www.midnight-commander.org/wiki/doc/editor/hotkeys

Currently, pressing CTRL+X in MCEDIT does nothing, and pressing CTRL+Z sends the editor to background and brings up the shell.

This is wrong, inconvenient (at least to old-timers) and the commonly known behaviour should be restored (maybe as an option enabled in run-time configuration menu, or via command-line).

This was currently verified with mc-4.7.0.2 compiled for Solaris 10 by www.sunfreeware.com, now trying to compile a more recent version to see if this bug still exists in 4.7.0.9 or 4.7.4...

Thanks,
Jim Klimov

Change History

comment:1 Changed 9 years ago by andrew_b

  • Component changed from mc-core to mc-key-bindings

comment:2 Changed 9 years ago by zaytsev

  • Cc zaytsev added

Do you have any relationship with SunFreeWare? or BlastWave? btw? SFW package is at 4.7.0.2, CSW is still at 4.6.2. It's nice to get them both up to date...

comment:3 Changed 9 years ago by jimklimov

  • Cc jimklimov@… added

Alas, no specific relationship except occasional emails.

I tried once to pass a few packages to Steve (maintainer of SFW) so he'd publish them, but in the end he remade similar packages according to his procedure. Which is different from publishing *my* packages, but reached the goal of having *anything* available :)

I have compiled mc-4.7.0.9 and 4.7.4 on Solaris (OpenSolaris? SXCE snv_117 actually), they both have the same problem regarding MCEDIT key bindings.

On a side note, for mc-4.7.4 I've got a conflict between an older (OS) and a newer (SMC) glib-2.0 versions. No such problem for mc-4.7.0.9 on the same system...

comment:4 Changed 9 years ago by zaytsev

The key bindings will be fixed in 4.7.5. We just forgot to add them to the keymap files.

The version of glib dep have been tightened in 4.7.4, so if you have multiple versions of glib, it's no good.

In what concerns the repos, I've got it. I don't particularly like the way Steve handles this, CSW non0intrusive packaging style is much more to my liking. Oh well, if I'll have to go on with Solaris, maybe I'll just figure out how to submit updates for CSW stuff.

Thanks!

comment:5 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Keywords stable-candidate added; mcedit ctrl+z ctrl+x removed
  • Version changed from 4.7.0.2 to master
  • Milestone changed from 4.7 to 4.7.5
  • Owner set to andrew_b

Created 2404_mcedit_shortcuts branch. Parent branch is master.
changeset:0908c8baea7f85aab153fbd815fda7fdfdf6bb6d

comment:6 Changed 9 years ago by zaytsev

  • Votes for changeset set to zaytsev

comment:7 Changed 9 years ago by angel_il

  • Votes for changeset changed from zaytsev to zaytsev angel_il
  • severity changed from on review to approved

comment:8 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Keywords stable-candidate removed
  • Votes for changeset changed from zaytsev angel_il to committed-master committed-stable
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 9 years ago by andrew_b

  • Status changed from testing to closed

comment:10 Changed 9 years ago by jimklimov

Confirm, patch works for both 4.7.0.9 and 4.7.4.

Albeit it's a small fix, I'm astonished by the small latency of your reaction! You rock, guys! ;)

Thanks, MC is now even more usable, again! :)
Jim Klimov

Note: See TracTickets for help on using tickets.