Ticket #2372 (closed defect: fixed)

Opened 14 years ago

Last modified 13 years ago

Editor sometimes shows russian UTF-8 chars as two dots

Reported by: victor-homyakov Owned by: angel_il
Priority: minor Milestone: 4.8.1
Component: mcedit Version: master
Keywords: Cc: zaytsev
Blocked By: Blocking: #2631
Branch state: merged Votes for changeset: committed-master, committed-stable

Description

Sometimes when editing big texts containing mixed english/russian words (UTF-8 encoding) editor shows two dots instead of some letter. When moving text cursor after that letter it will be displayed properly. When moving cursor back (before letter) it will be displayed again as two dots.

I have seen this bug in all 4.7.0.X versions I've used (4.7.0.pre4, 0.2, 0.3, 0.5, 0.9).

Attachments

Снимок 1.png​ (125.3 KB) - added by victor-homyakov 14 years ago.
Снимок 2.png​ (125.8 KB) - added by victor-homyakov 14 years ago.
example.sql.gz​ (92.9 KB) - added by victor-homyakov 14 years ago.
Example file
example.txt.gz​ (3.1 KB) - added by angel_il 14 years ago.
example
2372_fix.diff​ (1.7 KB) - added by angel_il 14 years ago.
fix
mc-4.7.5.5-mceditutf8fix.patch​ (862 bytes) - added by sergem 13 years ago.
simplified version of the 2372_fix.diff, cosmetics

Change History

Changed 14 years ago by victor-homyakov

Changed 14 years ago by victor-homyakov

comment:1 follow-up: ↓ 3 Changed 14 years ago by zaytsev

  • Cc zaytsev added

Do you have a minimal example file? I've never seen this before.

comment:2 Changed 14 years ago by andrew_b

  • Summary changed from Editor sometimes replaces russian UTF-8 chars with two dots to Editor sometimes shows russian UTF-8 chars as two dots

Changed 14 years ago by victor-homyakov

Example file

comment:3 in reply to: ↑ 1 Changed 14 years ago by victor-homyakov

Replying to zaytsev:
Gzipped example added as attachment.

comment:4 Changed 14 years ago by angel_il

can you show minimal steps to reproduce trouble with dots on your file?

comment:5 Changed 14 years ago by angel_il

i saw a problem, i will try to fix it

Changed 14 years ago by angel_il

example

comment:6 Changed 14 years ago by victor-homyakov

This bug can be related to part 2 of bug #1730 (UTF-8 char on 4K boundary)

Changed 14 years ago by angel_il

fix

Changed 13 years ago by sergem

simplified version of the 2372_fix.diff, cosmetics

comment:7 Changed 13 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted
  • Version changed from 4.7.0.9 to master
  • Branch state set to on review
  • Milestone changed from 4.7 to 4.8

branch: ​2372_mcedit_utf8_fix

please review

comment:8 Changed 13 years ago by andrew_b

  • Blocking 2631 added

comment:9 Changed 13 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Milestone changed from 4.8 to 4.8.1

comment:10 Changed 13 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

comment:11 Changed 13 years ago by angel_il

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 13 years ago by angel_il

  • Status changed from testing to reopened
  • Resolution fixed deleted

comment:13 Changed 13 years ago by angel_il

  • Votes for changeset changed from andrew_b angel_il to committed-master

comment:14 Changed 13 years ago by angel_il

fixed 41712de85c9cb8483baba921409ea3334966af4b (master)

comment:15 Changed 13 years ago by andrew_b

  • Branch state changed from approved to merged

comment:16 Changed 13 years ago by andrew_b

  • Keywords stable-candidate added

comment:17 Changed 13 years ago by angel_il

  • Status changed from reopened to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master, committed-stable
  • Resolution set to fixed

cherry-picked: 75139a565adf4c55fe60772c3de10ca424e2c71f, 2eddd75d73955bfd2168c18c0eb0bd6f959c6ecf

Note: See TracTickets for help on using tickets.