Ticket #2368 (closed defect: fixed)

Opened 12 years ago

Last modified 8 months ago

Panel sorting swaps with panels - for a while

Reported by: gotar Owned by: andrew_b
Priority: minor Milestone: 4.8.0-pre1
Component: mc-core Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

After CmdSwapPanel (ctrl-u) panels sortings swap as well, but only until next reread (either by ctrl-r or chdir), then it backs, e.g.:

  1. left: order by name, right: by size,
  2. ctrl-u,
  3. left: order by size, right: by name,
  4. ctrl-r, (tab, ctrl-r),
  5. left: order by name, right: by size.

Before this glitch could be fixed the question must be answered, either sorting should follow it's panel while swapping, or not. Currently - it doesn't (except for temporary initial state), sorting sticks to it's side (left-right/top-bottom).

Change History

comment:1 in reply to: ↑ description ; follow-up: ↓ 2 Changed 12 years ago by andrew_b

Replying to gotar:

the question must be answered, either sorting should follow it's panel while swapping, or not.

I'd prefer that all panel options must follow the panel because panel options are options of panel not options of panel location.

comment:2 in reply to: ↑ 1 Changed 12 years ago by gotar

On the opposite - what's the point of swapping panels along with their options? Then it's position only, mostly irrevelant, while swapping contents without options gives user a possibility to quickly peek on something and get back to primary view.
So after consideration I'd prefer to swap panels locations only.

comment:3 Changed 12 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.5

Created 2368_swap_panels branch.
Initial changeset:8ffbe19a9a8ce0fcecdb5a6597fe4311e8571297

comment:4 Changed 12 years ago by andrew_b

  • Version changed from 4.7.4 to 4.7.5
  • severity changed from on review to on rework
  • Milestone changed from 4.7.5 to 4.8

I think we should add an option to switch the mode of file listing panel swapping:

  • trivial swap, the swap of panel positions. Panel content and all panel options follow for the panel.
  • swap of panel content, as is at the current time (default).

comment:5 Changed 12 years ago by andrew_b

  • severity changed from on rework to on review
  • Milestone changed from 4.8 to 4.8.0-pre1

Modified and rebased to current master.
Initial changeset:cfe4cec24b51658d46799b91ee983d3c2ce2376d

comment:6 Changed 12 years ago by slavazanko

  • Keywords stable-candidate added
  • Votes for changeset set to slavazanko

comment:7 Changed 12 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:8 Changed 12 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:338ad4a9823e6a36d14f692c374e62d73887d58a

git log  --pretty=oneline 7285968..338ad4a

comment:9 Changed 12 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.6.5-stable.
Initial changeset:fdada761f121580fffd3f00d971e09505c0f7975

git log --pretty=oneline 0213c31..545baef

comment:10 Changed 8 months ago by cri

  • Branch state set to no branch

Please note that the original problem still remains: in default mode, after the swap, the sorting order indicators in the header line on top of the screen are inconsistent with the actual sorting order of files in the panels.

This is confusing for the user, as it takes a manual reload on both panels to fix the inconsistency.

Expected behaviour: swapping the panels should automatically reload panels to make their content consistent with the sorting order settings.

comment:11 Changed 8 months ago by andrew_b

  • Branch state changed from no branch to merged

Thanks for the report.
Fixed in 4270_cleanup branch: [5fa7c2c019e23de5626d5588ae51fb3316c39273].

Note: See TracTickets for help on using tickets.