Ticket #2366 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

ignore_dirs not working

Reported by: juangiordana Owned by: andrew_b
Priority: major Milestone: 4.7.5
Component: mc-core Version: 4.7.4
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

$ cat ~/.mc/ini

[FindFile]
ignore_dirs=/srv/www/site.org/www/media

$ mc -V

GNU Midnight Commander 4.7.4
Virtual File Systems: cpiofs, tarfs, sfs, extfs, undelfs, ftpfs, fish
With builtin Editor
Using the ncurses library
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

Change History

comment:1 follow-up: ↓ 2 Changed 9 years ago by andrew_b

  • Keywords ignore_dirs removed
  • Component changed from mc-search to mc-core

comment:2 in reply to: ↑ 1 Changed 9 years ago by juangiordana

Replying to andrew_b:

Follow up:

If "Start at:" is set to an absolute path then "ignore_dirs" works as expected, but by default "Start at:" is set to current directory "." and that seems to be the problem.

Works:

Start at: /srv/www/site.org
"ignore_dirs=/srv/www/site.org/www/media" 

Doesn't Work:

Start at: .
"ignore_dirs=/srv/www/site.org/www/media" 

Might be related to https://midnight-commander.org/ticket/2275 ?

Also "Start at:" isn't reset for new searches on other directories (or not), which very is annoying and will cause problems.

comment:3 Changed 9 years ago by gotar

  • Cc gotar@… added

comment:4 Changed 9 years ago by andrew_b

  • Blocking 2275 added

comment:5 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:6 Changed 9 years ago by andrew_b

  • severity changed from no branch to on review

Created 2366_find_ignore_dirs branch. Parent branch is master.
Initial changeset:18430a0c097aaf24844eab8cd4cdca33018b4103

comment:7 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:8 Changed 9 years ago by andrew_b

  • Votes for changeset slavazanko deleted
  • severity changed from on review to on rework

There are some bugs in branch. Rework is needed.

comment:9 Changed 9 years ago by andrew_b

  • severity changed from on rework to on review

Fixed. New initial changeset:778056b4f19af632580afd53845c34a88801481e.
Please review again.

comment:10 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:11 follow-up: ↓ 12 Changed 9 years ago by zaytsev

Unification of invali*f* filename skip.

comment:12 in reply to: ↑ 11 Changed 9 years ago by andrew_b

Thanks! Fixed.

comment:13 Changed 9 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:14 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged
  • Milestone changed from 4.7 to 4.7.5

Merged to master.
changeset:aa2e4fc7e7f3ea51525735c1114befe681ae70f9

git log --pretty=oneline 6bdcd48..aa2e4fc

comment:15 Changed 9 years ago by andrew_b

  • Status changed from testing to closed

comment:16 Changed 8 years ago by andrew_b

  • Blocking 2275 removed
Note: See TracTickets for help on using tickets.