Ticket #2347 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

Hardcoded FISH scripts do not work properly

Reported by: gms Owned by: angel_il
Priority: major Milestone: 4.7.5
Component: mc-vfs Version: master
Keywords: Cc: gotar@…, zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by zaytsev) (diff)

It is not possible to enter any remote diectory except "/" and view any file.

Change History

comment:1 follow-up: ↓ 6 Changed 9 years ago by andrew_b

Telepathy module is totally broken.

What are you doing? What system are you using?

comment:2 Changed 9 years ago by gotar

  • Cc gotar@… added
  • Priority changed from major to trivial

Probably he didn't install separated #2242 files or took some broken distro package. Anyway contrib/dist/redhat/mc.spec.in doesn't seem to include them too.

comment:3 Changed 9 years ago by andrew_b

Hm.. rpmbuild show a message about unpacked files in $BUILDROOT. Package builder should look to that messages.

comment:4 Changed 9 years ago by andrew_b

But anyway. mc.spec.in must be fixed.

comment:5 Changed 9 years ago by zaytsev

  • Cc zaytsev added
  • Version changed from 4.7.4 to master

After the buildbot was destroyed the SPEC is no longer kept current. I have finally created a new KVM host for restoring the buildbot, but I don't have time to setup mock and the whole thing. I hope to get to it sooner or later. Maybe in a few weeks.

comment:6 in reply to: ↑ 1 Changed 9 years ago by gms

Replying to andrew_b:

Telepathy module is totally broken.

What are you doing? What system are you using?

I'm using Debian.
In mc 4.7.3 FISH works well, configure options were the same.

comment:7 follow-up: ↓ 9 Changed 9 years ago by zaytsev

You are kidding??? Where is mc -V ? Which configure options?

comment:8 Changed 9 years ago by zaytsev

aptitude show mc

comment:9 in reply to: ↑ 7 Changed 9 years ago by gms

Replying to zaytsev:

You are kidding??? Where is mc -V ? Which configure options?

LANG=C ./mc -V
GNU Midnight Commander 4.7.4
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

LANG=C mc -V
GNU Midnight Commander 4.7.3
Virtual File Systems: tarfs, extfs, cpiofs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

comment:10 Changed 9 years ago by zaytsev

Where did you get it? Compiled from source? How did you install it? Are the FISH scripts in place?

comment:11 Changed 9 years ago by gms

Hmm... this bug occurs only when create a debian package (but all the files are in place).
Thanks 2 all!

comment:12 follow-ups: ↓ 13 ↓ 14 Changed 9 years ago by zaytsev

How did you create a package? How do you know they are in place?

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

comment:13 in reply to: ↑ 12 Changed 9 years ago by andrew_b

Replying to zaytsev:

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

Generally they work but some bugs are present. :)

comment:14 in reply to: ↑ 12 Changed 9 years ago by gms

Replying to zaytsev:

How did you create a package? How do you know they are in place?

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

When i do

#./configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib;make;make install

anything works,but when i build deb with debian files from ftp://ftp.debian.org/debian/pool/main/m/mc/mc_4.7.0.9-1.debian.tar.gz

#fakeroot debian/rules binary
#dpkg -i mc_4.7.4-1_i386.deb

FISH becobes broken.
PS: other VFS's still work fine

comment:15 Changed 9 years ago by angel_il

  • severity changed from no branch to on review

Branch: 2347_fish_fix
changeset: f6309b162ea464c7cd3ce0f2903871065f8734e9

comment:16 Changed 9 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:17 Changed 9 years ago by zaytsev

Of course if you build a package for 4.7.4 from my sources for 4.7.0.9 FISH scripts are not going to be installed where they belong. What else did you expect??? New FISH is not backported yet to the stable branch.

What I find annoying is that instead of providing all the details at once, we have to fish them out of you one by one.

comment:18 Changed 9 years ago by zaytsev

  • Description modified (diff)
  • Summary changed from Bug in FISH to Hardcoded FISH scripts do not work properly

comment:19 Changed 9 years ago by andrew_b

  • Priority changed from trivial to major
  • Votes for changeset set to andrew_b
  • Milestone changed from 4.7 to 4.7.5

comment:20 Changed 8 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:21 Changed 8 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:22 Changed 8 years ago by slavazanko

  • Keywords stable-candidate added

comment:23 Changed 8 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed

Fixed in 4.7.0-stable in #2376.

comment:24 Changed 8 years ago by andrew_b

Oops, sorry...
Fixed in 4.7.0-stable in #2367.

Note: See TracTickets for help on using tickets.