Ticket #2296 (closed defect: duplicate)

Opened 8 years ago

Last modified 8 years ago

slang import broken

Reported by: metux Owned by:
Priority: major Milestone: 4.7
Component: mc-core Version: master
Keywords: Cc: weigelt@…, zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

The slang importing is conceptionally broken:

a) it does not use the pkgconfig descriptor (PKG_CHECK_MODULES)
b) adds absolte pathes, which breaks many environments (especially crosscompiling)

Change History

comment:1 follow-up: ↓ 3 Changed 8 years ago by zaytsev

  • Cc zaytsev added

What's the point of creating a new ticket, when there's already #2139 dedicated to this issue? Did you implement the fallback to the path-based configuration when pkgconfig script is not available as requested?

comment:2 Changed 8 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to duplicate

comment:3 in reply to: ↑ 1 Changed 8 years ago by metux

Replying to zaytsev:

What's the point of creating a new ticket, when there's already #2139 dedicated to this issue?

Oh, sorry, forgot that there's already a ticket ... ;-o

Did you implement the fallback to the path-based configuration when pkgconfig script is not available as requested?

According to mc-with-screen-slang.m4, slang version >= 2.0 is required, which has an pkg-config descriptor.
So, detecting via compile-test is not just totally obsolete, but conceptionally wrong. (if the pkg-config descriptor is missing, the package is not properly installed).

Needless to say, that AC_TRY_RUN() _breaks_ any clean isolated build (not just crosscompiling).

comment:4 Changed 8 years ago by zaytsev

I don't have any pkgconfig script shipped with slang-2.0.6-4 on RHEL5. andrew_b doesn't have it on his (more recent) box either. I'm not against using pkgconfig, but a fall-back should be properly implemented.

Note: See TracTickets for help on using tickets.