Ticket #2292 (closed defect: fixed)

Opened 9 years ago

Last modified 5 years ago

mcview: CJK character dropped at linewrap

Reported by: egmont Owned by: angel_il
Priority: major Milestone: 4.8.14
Component: mcview Version: 4.7.3
Keywords: Cc:
Blocked By: Blocking: #3248
Branch state: no branch Votes for changeset:

Description

View a file containing lots of double width characters (just as the attached one) in mcview. Turn on wordwrapping.

When a full CJK character doesn't fit at the end of the line (there's only a single cell remaining), a '>' sign is shown, and this CJK character is dropped. The next line continues with the character after this. (See screenshot, the first example is: the middle letter of the double-wide "the" word is not displayed.)

In order to be able to read the text, the character that doesn't fit in the first line should entirely go to the second. The first line should end with a space character. (By the way, this is what CJK-aware terminals do when you simply cat the file.)

Attachments

cjk_quick_brown.txt (1.3 KB) - added by egmont 9 years ago.
cjk_quick_brown.png (30.8 KB) - added by egmont 9 years ago.
cjk_quick_brown_cat.png (28.2 KB) - added by egmont 9 years ago.
expected wrapping

Change History

Changed 9 years ago by egmont

Changed 9 years ago by egmont

Changed 9 years ago by egmont

expected wrapping

comment:1 Changed 9 years ago by andrew_b

  • Component changed from mc-core to mcview

comment:2 Changed 8 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:3 Changed 8 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:4 Changed 5 years ago by egmont

  • Blocking 3248 added

comment:5 Changed 5 years ago by egmont

The '>' sign is slang's choice when a CJK is printed in the rightmost column of the terminal. Ncurses uses a space instead.

When the viewer doesn't take up the whole width of the terminal (e.g. one of the file manager panels is in "Quick view" mode), such CJK characters overflow out of the viewer into the frame.

Obviously, both in wrap and unwrap mode, mcview should be clever enough never to print a CJK that would overflow from the actual viewer area.

comment:6 Changed 5 years ago by egmont

This was fixed in #3250, please close the bug.

comment:7 Changed 5 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:8 Changed 5 years ago by andrew_b

  • Milestone changed from Future Releases to 4.8.14

comment:9 Changed 5 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.