Changes between Version 1 and Version 2 of Ticket #2290, comment 11


Ignore:
Timestamp:
07/31/13 18:57:33 (11 years ago)
Author:
sknaumov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2290, comment 11

    v1 v2  
    77> I guess this doesn't give us a large profit, but... 
    88Actually this patch slows down things a lot. On my new Virtualbox setup (Xubuntu 13.04, VDI image is on SSD) this patch increases search time from 17,5 to 20,65 seconds. Maybe using glib functions like g_string_append_c is very inefficient approach, but... 
    9 Passing pointer to variable on stack to get_line_at function and setting resulting string length to it surprisingly increases search time to 19.3 seconds. Usage of global variable to pass length from get_line_at to mc_search_run decreases search time to 17.2 seconds. 
     9Passing pointer to variable on stack to get_line_at function and setting resulting string length to it surprisingly increases search time to 19.3 seconds. Usage of global variable to pass length from get_line_at to mc_search_run decreases search time to 17.2 seconds. Sounds a bit unreal, but I launched tests three times in a row and results were repeatable. 
     10 
     11Usage of SIGALARM and checking per line whether 1 second passed since previous status update reduces search time to 15.7 seconds. Now I should check whether this change improves or decreases performance in native case. 
     12 
     13UPDATE: on VirtualBox times seem to change a bit from one "make install" to another, but not so much. Have to check everything on native system at work.