Ticket #2280 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

comments in trac are not numbered

Reported by: ossi Owned by: zaytsev
Priority: minor Milestone:
Component: adm Version:
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

the titles of comments in tickets contain no number, which makes it hard to refer to them. that the reply function creates references with actual numbers makes it look outright silly ...

Change History

comment:1 Changed 9 years ago by andrew_b

What do you propose?

comment:2 Changed 9 years ago by ossi

i don't know. the comment titles are a somewhat weird "Changed 29 minutes ago by andrew_b", and so on. maybe put that as "comment #1 from 29 minutes ago by andrew_b" or something like that.

comment:3 in reply to: ↑ description Changed 9 years ago by x905

Replying to ossi:

the titles of comments in tickets contain no number

need to change /usr/local/share/trac/templates/ticket.cs (or where it located) and add "<?cs var:change.cnum?>" to where header forms (i tested it on my local trac 0.10.4)

comment:4 Changed 9 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

Will do. Thanks.

comment:5 Changed 9 years ago by andrew_b

And after the Trac upgrade this change will be missed. Is such feature available in new Trac out-of-box or in any plug-in?

comment:6 follow-up: ↓ 7 Changed 9 years ago by zaytsev

Not that I know of. Either way we already have some customizations to the core and plugins, so an upgrade is tricky business... This is not only Trac's problem, but web-apps in general. That's why there are many opponents to actually packaging them vs. installing and updating manually.

I guess the best bet for the upgrade would anyway be to do a diff against stock versions of Trac and plugins and then try to re-apply relevant changes.

comment:7 in reply to: ↑ 6 Changed 9 years ago by gotar

  • Cc gotar@… added

Replying to zaytsev:

That's why there are many opponents to actually packaging them vs. installing and updating manually.

That's exactly why every piece of software in a system should came from a package. This way one gets:

  1. checksums (easy do detect in-place changes),
  2. backups (e.g. via rpm's repackage function),
  3. source of all the patches and modifications (in src.rpm).

comment:8 follow-up: ↓ 9 Changed 9 years ago by zaytsev

Did you ever tried to do this in practice with the regards to the web applications or it's just a wishful thinking?

On the practical side, this server runs Debian and creating a local Trac fork is such a pita, that it's easier to kill yourself. And even if the overhead of Debian re-packaging can be justified it's extremely complicated to convert an existing setup given how messy and undocumented it is.

Let's see. One day I will get some time... Maybe. Or someone else.

comment:9 in reply to: ↑ 8 Changed 9 years ago by gotar

Replying to zaytsev:

Did you ever tried to do this in practice with the regards to the web applications or it's just a wishful thinking?

Of course I did. I've got to manage bunch of webapps on dozen servers, it would be impossible to maintain them other way. Some changes are even pushed into distro (e.g. http://cvs.pld-linux.org/cgi-bin/cvsweb/packages/phpPgAdmin/phpPgAdmin-calendar.patch), same reason as for #1668 and #2135 in PLD package (no upstream fixes).

On the practical side, this server runs Debian and creating a local Trac fork is such a pita, that it's easier to kill yourself.

Who said 'fork'? Keep your changes in diff format, they rarely need some minor updates only.

And even if the overhead of Debian re-packaging can be justified it's extremely complicated to convert an existing setup given how messy and undocumented it is.

Well, if someone didn't think on proper procedures then, either the time is now ...or postpone it until some else does it.

Let's see. One day I will get some time... Maybe. Or someone else.

:)

But seriously: take original deb package of currently installed version, create diff, try to apply it on some new version.

comment:10 Changed 9 years ago by zaytsev

Well, I do manage phpMyAdmin and phpPgAdmin, cacti and the like this way, but it's a very special case of a webapp. We are talking about Trac here, which requires much more (tremendously more) customization than those.

Well, if someone didn't think on proper procedures then, either the time is now ...or postpone it until some else does it.

Exactly. Fortunately it was not me (I wouldn't have gone for Debian in the first place), thus I have another person to blame =) Hi, Winnie! :)

But seriously: take original deb package of currently installed version, create diff, try to apply it on some new version.

This is what I meant by forking and this would probably the way to go, but Debian packaging system is so over-engineered, that it's by now ways as simple as just rebuilding your noarch SPECs with appropriate patches. You have dozens of files to keep in sync and so on...

As I said, let's see. Actually I'd like to have the whole setup re-done properly and this time appropriately DOCUMENTED. One day.

comment:11 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Version master deleted
  • Resolution set to fixed

Fixed by Trac upgrade to 0.12.2 version.

comment:12 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.