Ticket #2266 (closed enhancement: fixed)
filtered view default text
| Reported by: | ForeverYoung | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | trivial | Milestone: | 4.8.0-pre1 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | gotar@… | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | commited-master |
Description
I suggest changing default text in filtered view (alt-!) command input line instead current filename in panel to contents of cmdline.
It's easier to edit command line with commands like alt-tab, alt-enter, etc., and then view the result in mcview.
Attachments
Change History
comment:1 Changed 14 years ago by gotar
- Cc gotar@… added
- Milestone changed from Future Releases to 4.7.4
comment:2 Changed 14 years ago by andrew_b
- Version changed from version not selected to master
- Milestone changed from 4.7.4 to 4.7
comment:4 Changed 14 years ago by slavazanko
- Milestone changed from 4.7 to 4.8
No-no, don't worry. We review attached patch ASAP.
comment:5 in reply to: ↑ description Changed 14 years ago by andrew_b
Replying to ForeverYoung:
I suggest changing default text in filtered view (alt-!) command input line instead current filename in panel to contents of cmdline.
Command line should be used if it is not empty.
comment:6 Changed 14 years ago by slavazanko
- Owner set to slavazanko
- Status changed from new to accepted
- severity changed from no branch to on review
Created branch 2266_filtered_view
changeset:c1fe895ff66d207c3cb7e11417aec2ac9930337f: filtered view default text
Review, please.
comment:7 Changed 14 years ago by slavazanko
Sorry, initial changeset is 9bb7972e46a60e6c64e068e40a5c91d2fa77a203
comment:8 Changed 14 years ago by andrew_b
- Milestone changed from 4.8 to 4.8.0-pre1
Whether the command line should be cleaned after return from viewer? Or even before run viewer?
comment:9 follow-up: ↓ 10 Changed 14 years ago by gotar
In some cases - definitely not; one might make a typo or run some commands in sequence (e.g. changing some text in the middle, so cursor position shouldn't be altered) or use command line as a template, not to mention active marks. So at least some conditions should be met, like:
- exactly the same executed in filtered view,
- exit code == 0,
- cursor located at the beginning or the end of a command line,
- no marks.
But I don't think changing behaviour in every other case is a good idea - people would rather think that sometimes mc looses command line. And clearing it is ctrl-w ctrl-k combo (or enter).
comment:10 in reply to: ↑ 9 Changed 14 years ago by andrew_b
Replying to gotar:
In some cases - definitely not; one might make a typo or run some commands in sequence (e.g. changing some text in the middle, so cursor position shouldn't be altered) or use command line as a template, not to mention active marks.
At the opposite: command line has a history. The run command can be restored from history.
comment:11 Changed 14 years ago by gotar
I thought about it, but history doesn't restore marks and cursor position.
comment:13 Changed 14 years ago by angel_il
- Votes for changeset changed from andrew_b to andrew_b angel_il
comment:15 Changed 14 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
