Ticket #2252 (new enhancement)

Opened 9 years ago

Last modified 3 years ago

build system causing waaaay too many rebuilds

Reported by: ossi Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc: mooffie@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

the build system puts the git version into config.h, which basically means that each git operation which modifies HEAD will cause a full rebuild. this is highly annoying, in particular during bisecting.

i suggest throwing VERSION out of config.h and having the relevant files include version.h directly. that would also have the advantage of removing the version.h parsing from the configure script.

Change History

comment:1 in reply to: ↑ description Changed 9 years ago by andrew_b

Replying to ossi:

removing the version.h parsing from the configure script.

version.h is parsed to set correct version of RPM and DEB packages during automatic build of master branch (see #1905).

comment:2 Changed 9 years ago by ossi

it would be possible to do the substitutions as a dependency (or part) of the respective packaging targets - the package definition files need only one or two substitutions each, so it isn't particularly bothersome. definitely better than re-running configure each time ...

comment:3 Changed 9 years ago by slyfox

It's also used in contrib/dist/redhat/mc.spec.in, so it might be not so trivial.
Simpler solution would be to put some hack to version.sh which would disable or force certain nonchanging version ID.

comment:4 Changed 9 years ago by ossi

it's just one file more, so why would it matter?

i already thought about the hardcoded version hack as well, but it's rather annoying to use (for one, activating it already requires a recompile).

comment:5 Changed 8 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:6 Changed 5 years ago by andrew_b

Ticket #3153 has been marked as a duplicate of this ticket.

comment:7 Changed 4 years ago by mooffie

  • Cc mooffie@… added

comment:8 Changed 3 years ago by andrew_b

Related to #3603.

Note: See TracTickets for help on using tickets.