Ticket #2250 (testing enhancement: fixed) — at Version 9
iso case insensitivity for mc.ext
| Reported by: | nerijus | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.5 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: |
Description (last modified by andrew_b) (diff)
Please apply, there are quite a lot .ISO files:
--- mc.ext.orig 2010-06-16 11:55:31.000000000 +0300
+++ mc.ext 2010-06-29 03:14:58.163560374 +0300
@@ -239,7 +239,7 @@
View=%view{ascii} apt-cache show echo %p | sed 's/\([0-9a-z.-]*\).*/\1/'
# ISO9660
-regex/\.iso$
+regex/\.([iI][sS][oO])$
Open=%cd %p#iso9660
View=%view{ascii} isoinfo -l -i %f
Change History
comment:1 follow-up: ↓ 6 Changed 14 years ago by zaytsev
- Status changed from new to accepted
- Owner set to zaytsev
- Version changed from 4.7.2 to master
- Milestone changed from 4.7 to 4.7.3
comment:2 follow-up: ↓ 3 Changed 14 years ago by ossi
i think it would be a good idea if the matching expressions had the possibility to be case-insensitive (and it would probably make sense if that option was on by default, except that doing so now would make existing .ext files incompatible). possible syntaxes are:
shell/.iso/i
or
shell:i/.iso
the first variant looks more familiar and nicer, while the second one can be guaranteed to be backwards-compatible without quoting slashes in the pattern somehow (though that would be relevant only for the directory keyword, which is practically unused, so it may be acceptable to add new quoting rules to it).
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 14 years ago by andrew_b
I think we need a special ticket for modification of .ext file processing.
comment:5 Changed 14 years ago by ossi
nah, that ticket is "too big", this minor enhancement will drown there. however, it is probably true that #2118 would supersede my suggestion when finally implemented.
anyway, i think you are seriously overdoing it with the processes. ;)
just apply the patch "silently" to the cleanup branch (if you *want* to have it in right now) and repurpose the ticket for my more general approach to the problem.
comment:6 in reply to: ↑ 1 Changed 14 years ago by andrew_b
Replying to zaytsev:
May I just put this into cleanup, guys, sounds trivial enough to not mess anything up?
I don't mind.
As per WorkingGuidelines? for mc.ext a branch is needed. May I just put this into cleanup, guys, sounds trivial enough to not mess anything up?