Ticket #2247 (closed task: wontfix)

Opened 11 years ago

Last modified 12 months ago

install code review plugin for trac

Reported by: ossi Owned by:
Priority: minor Milestone:
Component: adm Version:
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

in *addition* to other workflows for code review (in particular the purely mail-based one), it may be useful to have a proper tool for on-line patch review.

i found the following plugins:

outside trac-land, ReviewBoard? is *the* benchmark. Gitorious is catching up as well, but is still inferior.

Change History

comment:1 Changed 11 years ago by zaytsev

  • Cc zaytsev added

comment:2 follow-up: ↓ 3 Changed 11 years ago by zaytsev

What I really don't understand is how this fits into your dream "e-mail only" workflow... It's GUI / browser based and it's AJAX. I can imagine people commenting on the individual commits to the branches that are getting created for specific tickets, but I see no way of doing this kind of code review using this plugin.

And, by the way, I am not really sure how it plays with Git.

comment:3 in reply to: ↑ 2 Changed 11 years ago by ossi

Replying to zaytsev:

how this fits into your dream "e-mail only" workflow...

it doesn't. however, if done right, it does add enough value that i would consider it for bigger reviews. and for those who *want* to work with a web interface, it should be a no-brainer anyway.

And, by the way, I am not really sure how it plays with Git.

that is for you (plural) to find out. :)

comment:4 Changed 11 years ago by andrew_b

  • Type changed from enhancement to task

comment:5 follow-up: ↓ 6 Changed 8 years ago by ossi

  • Branch state set to no branch

with the move of the authoritative repo to github, the obvious move would be using github's review infrastructure instead of trac now.

comment:6 in reply to: ↑ 5 Changed 6 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to wontfix

Replying to ossi:

with the move of the authoritative repo to github, the obvious move would be using github's review infrastructure instead of trac now.

Yes.

comment:7 Changed 6 years ago by zaytsev

I agree with closing the ticket, but I'm not sure if we really want to use more of pull requests. There was a message from @ossi to the mailing list awhile ago, to which I sadly never found time to reply and share my experiences / make some specific suggestions. Maybe we should revive this thread at some point...

Anyways, to make a long story short, I'm currently using Upsource at work, and I'm quite ecstatic about it. A problem that I foresee with using Upsource for a project like mc, is that it currently doesn't work very well with force-pushes of a branch. Upcoming versions of Upsource will integrate with GitHub, so maybe we should really give it a try.

Only need to find time to set it up (just as usual...) and where to host it, as it's rather a resource hungry beast :-/

comment:8 Changed 12 months ago by ossi

for reference, that message was https://mail.gnome.org/archives/mc-devel/2015-May/msg00100.html.

having gone through the contrib process recently, i'd really like to see something being done about that.

one thing to aim for is leveling the playing ground, which means making the contribution process the same for maintainers and outsiders (with the obvious difference of who may approve/integrate contributions).

i for one would just switch to https://gerrithub.io - it fits the bill, it's easy to do, and it can be tried out "for real" without making an up-front commitment.

Note: See TracTickets for help on using tickets.