Ticket #2198 (closed defect: fixed)

Opened 9 years ago

Last modified 6 years ago

Terminal settings not changed when window resize

Reported by: Spinal Owned by: andrew_b
Priority: major Milestone: 4.8.7
Component: mc-tty Version: 4.7.2
Keywords: Cc: andrixnet@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

1) It's done in Terminal used in XFce (if that's matter)
2) Launch Terminal, then start mc
3) Press Ctrl-O to go into console mode
4) Resize the window (I usually make it bigger)
5) Run some terminal app that usually uses full terminal width/height. I.e. vim, ufed or any other app/editor.
6) Its size will be less than it should be. If you change the window length/height, you won't get any success. The application will have fixed size/height.
That's probably the bug introduced in new-generation of midnight commander, developed by Slavaz. I don't have the same bug in mc-4.6.2-pre1 version used on my Debian Lenny server.

Thanks for your great work on improving mc!

Change History

comment:1 Changed 9 years ago by andrew_b

  • Component changed from mc-core to mc-tty

What Terminal version?
What shell is used and its version?
What screen library is used: S-Lang or NCurses?

comment:2 Changed 9 years ago by Spinal

x11-terms/terminal-0.4.4
app-shells/bash-4.0_p37
sys-libs/ncurses-5.7-r3

$ ldd which mc | egrep 'lang|ncurse'

libncursesw.so.5 => /lib/libncursesw.so.5 (0xb767a000)
libncurses.so.5 => /lib/libncurses.so.5 (0xb73f4000)

So probably it's not a slang version.

I'm Gentoo user. Please let me know if you need any assistance on fixing this bug.
Thank you.

comment:3 Changed 9 years ago by egmont

I've tested it with the following 4x2 combinations, on Mac OS 10.5:
{ 4.6.1, 4.6.2, 4.7.0.5, 4.7.2 } x { slang, ncurses }

It's always the ncurses build that doesn't resize properly, with any of those mc versions.

comment:4 in reply to: ↑ description Changed 8 years ago by andrew_b

  • Blocked By 117 added
  • Milestone changed from 4.7 to 4.8

Replying to Spinal:

That's probably the bug introduced in new-generation of midnight commander, developed by Slavaz.

Definetely, no.

I don't have the same bug in mc-4.6.2-pre1 version used on my Debian Lenny server.

Strange. I've tried 4.6.1 from repo, and it doesn't work also. It seems, subshell resizing in NCurses-based mc didn't work ever.

Replying to egmont:

I've tested it with the following 4x2 combinations, on Mac OS 10.5:
{ 4.6.1, 4.6.2, 4.7.0.5, 4.7.2 } x { slang, ncurses }

It's always the ncurses build that doesn't resize properly, with any of those mc versions.

Correct, it is an NCurses-related bug only. But implementation of window resize handling in S-Lang-based mc is not quite correct.

In general, the implementation of SIGWINCH signal handling in mc should be rewritten. One of possible way is described in #117.

comment:5 Changed 8 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.8 to Future Releases

comment:6 Changed 6 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Blocked By 117 removed
  • Milestone changed from Future Releases to 4.8.7

comment:7 Changed 6 years ago by andrew_b

  • Keywords stable-candidate added
  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from no branch to merged

comment:8 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset set to committed-master committed-stable

comment:9 Changed 6 years ago by andrixnet

  • Cc andrixnet@… added
Note: See TracTickets for help on using tickets.