Screen output can't handle non-printable characters

[gotar]

Comparing random binary files (or text files with not-LC_CTYPEd nor translated encoding) leads to garbages. It seems like there's no is_printable() checks or some are missing.

[angel_il]

mcdiff not for compare binary data

[gotar]

"or text files with not-LC_CTYPEd nor translated encoding"

Read carefully please. The same happens for UTF-8 files when I'm using ISO-8859-2 - in such case ctrl-E and choosing manually UTF-8 fixes the output. Comparing binary files is just the fastest way to show where the problem resides.

[angel_il]

"or text files with not-LC_CTYPEd nor translated encoding"

ok :)

[zaytsev]

Same issue as in #1668, isn't it?

[gotar]

Nope, it's not the same as #1668 - like I've noticed in #2502 it's related to '<MN>' hex representation of non-printable characters which causes expanding lines, but apparently they're not recalculated and put too wide directly on screen.

[angel_il]

so, i known about this bug... but 1) mcdiff not for HEX compare, 2) i'm so lazy for fix it...

[angel_il]

2gotar: you really have troubles with this behavior of the mcdiff?

[gotar]

Replying to angel_il:

2gotar: you really have troubles with this behavior of the mcdiff?

Not at all, it only badly wraps on screen, so doesn't corrupt it (unlike #1668 which is real PITA, I wonder why it's still not fixed upstream).
But this shows that some parts of code that could be common are not; mcview handles output (almost) properly, but lacks color support (#1849), two-panel viewer was requested somewhere here too AFAIR.

[andrew_b]

Related to #2162.