Ticket #2173 (closed enhancement: fixed)

Opened 9 years ago

Last modified 8 years ago

Warn if 256 colors are used but not available

Reported by: egmont Owned by:
Priority: minor Milestone: 4.8.0-pre1
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

This is the last bit I just did not have time and passion to add to the 256-color patch (ticket #2169).

If 256 colors are not available according to $TERM (ncurses: NCOLORS; slang: I don't know), but the requested color scheme would use any of these extended colors, currently some weird magic happens that is totally not user friendly (you end up with ugly or even unusable colors). Instead, mc could revert to the default skin (or keep the current one if dynamically changing: ticket #2165), and show an error message explaining to the user what happened.

Change History

comment:1 Changed 9 years ago by ossi

it should be possible to bind the color scheme setting to a particular $TERM, like is done with the key remappings. otherwise users who use two different terminal types (say, xterm and vga console) on a regular basis might be mightily annoyed.

comment:2 Changed 9 years ago by egmont

Yup great idea!
(By the way, the popup would still be nice to detect config errors or when the command line refers to an incompatible skin.)

comment:3 Changed 9 years ago by andrew_b

If user wants use 256-colors skin, he must choose the terminal with 256 colors support. I'm sure that mc should not be blamed for the fact that user tries to use 256-color skin in terminal which does not support 256 colors. mc should't do fallback itself to the any other skin.

comment:4 Changed 9 years ago by ossi

sorry, did you actually understand what we wrote? it doesn't seem so ...

comment:5 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.3 to 4.7.4

comment:6 Changed 8 years ago by andrew_b

  • Version changed from version not selected to master
  • Component changed from mc-core to mc-tty
  • Blocked By 2169 added
  • Milestone changed from 4.7.4 to 4.8.0-pre1

comment:7 Changed 8 years ago by slavazanko

  • Blocked By 2169 removed

(In #2169) merge changeset:6ab2753063c3f538fd6a545681873445ea10156f

[code]
git log --pretty=oneline 1b99570..0f2578d
code

comment:8 Changed 8 years ago by slavazanko

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in 2169

Note: See TracTickets for help on using tickets.