Ticket #2171 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

Hotkey color used for complete entries

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.7.5
Component: mc-skin Version: 4.7.2
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

For the F9 menu, "menuhot" and "menuhotsel" stand for the hotkey, the 1 letter that quickly accesses that menu. Hence the fragment "hot" in the name. "menusel" and "menuhotsel" stand for the one currently selected (hence "sel") by the cursor, that is, refers to a complete entry. So far it's okay.

The F2 or Alt-e menus, however, don't preserve this semantics. The whole selected line is printed in "menuhotsel" (unselected ones are printed in "_default_"). In ticket #2169 I propose a patch that allows skins to use underlined characters, and I wish to use that there in the sand256 skin, to be similar to the menus of graphical applications. Underlining the hotkey looks great, really. I can do it with the F9 menu, but not with the F2/Alt-e menus: the complete selected line gets underlined. I believe that F2/Alt-e menus should use "menusel" instead of "menuhotsel" for the selected entry. Actually, they could use all four colors: the "hot" variants for the hotkey column only.

The same goes for history windows: the highlighted entry gets the color of [dialog]->dhotfocus. As this is not a hotkey at all, and a complete line is highlighted, [dialog]->dfocus would be the correct color.

I understand that such a code change would cause a minor change in the appearance of mc. I think this change is acceptable - if not then please allow the F2/Alt-e and History menus to use brand new colors, independently of the current [menu] and [dialog] colors.

Attachments

mc-4.7.0.5-selected-vs-hotkey-color.patch (550 bytes) - added by egmont 9 years ago.
proof of concept: don't use hotkey colors for the selected entry
mc-4.7.0.5-popup-menu-uses-dialog-colors.patch (460 bytes) - added by egmont 9 years ago.
make popup menus use dialog colors rather than menu colors
mc-4.7.0.7-popup-menu-uses-dialog-colors.patch (583 bytes) - added by egmont 9 years ago.
update for newer mc (whitespace changes only)

Change History

comment:1 Changed 9 years ago by zaytsev

  • Cc zaytsev added

Personally, I have no problem with such minor changes in appearance. FYI.

comment:2 Changed 9 years ago by egmont

This actually broke somewhere between 4.6.2 and 4.7.0. Moreover, the colors of the F2 menu completely changed then: from dialog colors to menu colors (i.e. with the default skin: from black-on-white with cyan highlight, to white-on-cyan with black highlight). I'm not sure if any of these changes were intentional. (I really preferred the old colors for the F2 menu, IMHO they just look nicer.)

I haven't yet found the relevant places in the source code. Will keep on looking.

Changed 9 years ago by egmont

proof of concept: don't use hotkey colors for the selected entry

comment:3 Changed 9 years ago by egmont

Okay, I've attached a proof of concept. Currently, the hotkey+selected color is being used for a focused selected entry.

I have no clue what focused vs. unfocused actually means. Could you please help me and guide me to a use case where a widget is visible on the screen but unfocused? Maybe we'd need to introduce another color for that...?

Changed 9 years ago by egmont

make popup menus use dialog colors rather than menu colors

comment:4 Changed 9 years ago by egmont

And here's another patch, this one makes the F2 and Alt-e menus use dialog colors rather than menu colors; just as the history or quick cd menus do. This restores the look of mc-4.6.2, and I think those menus just look better with these colors (in the default skin).

comment:5 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.3 to 4.7.4

Changed 9 years ago by egmont

update for newer mc (whitespace changes only)

comment:6 Changed 8 years ago by slavazanko

  • Blocked By 2409 added

comment:7 Changed 8 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Component changed from mc-core to mc-skin
  • Milestone changed from 4.7.4 to 4.7.5

Created 2171_popup_menu_colors branch. Parent branch is master.
changeset: db26c00374dad1cad9fd4220f805530c9cfc4a2b

comment:8 Changed 8 years ago by andrew_b

  • severity changed from no branch to on review

comment:9 Changed 8 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:10 Changed 8 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:11 Changed 8 years ago by slavazanko

  • Blocking 2409 added

comment:12 Changed 8 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:13 Changed 8 years ago by andrew_b

  • Status changed from testing to closed

comment:14 Changed 8 years ago by andrew_b

  • Blocking 2409 removed
Note: See TracTickets for help on using tickets.