Ticket #2168 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Hotkey shouldn't be capitalized

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.7.3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

In some contexts, e.g. in the F9 menu, hotkeys are highlighted using a different color, no matter if it's an uppercase or lowercase letter. Capitalization of the letters is independent of the hotkey: the first letter, and acronyms are capitalized.

In some other contexts, e.g. in the file copy dialog, hotkeys are the ones that are capitalized, instead of the first letter. For example, there's a "diVe into subdir" instead of "Dive into subdir", since V is the hotkey.

These two looks are inconsistent. I think we should decide on one of the schemes and consistently go with that one.

I personally recommend going with the current scheme of the F9 menu. Hotkeys are already highlighted by the color; I don't see any point in using yet another attribute (uppercase) for emphasizing them even more. Capitalizing a letter in the middle of a word looks ugly. The scheme cannot really be used if there's an acronym, or at least it would really look weird. Moreover, some translations might already be using that scheme (I only checked Hungarian and that one is consistent with itself: even in the file copy dialog it always capitalizes the first word, not the hotkey.)

Change History

comment:2 Changed 9 years ago by slavazanko

What about languages without capitalized letters (Arabic, Japan, Chiese, Korean etc)?

comment:3 Changed 9 years ago by egmont

Using the terminology of that website, this bugreport is about mnemonics.

comment:4 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Blocked By 320 added

Most of this issues are fixed in #320.

comment:5 Changed 9 years ago by slavazanko

  • Blocked By 320 removed

comment:6 Changed 9 years ago by andrew_b

  • Version changed from 4.7.0.4 to master
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.3

Created 2168_capitalized_hotkeys branch. Parent branch is master.
changeset:cdc96f4f6d1299e3a4c7f55450b2749abf67ee90

comment:7 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:8 Changed 9 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il

comment:9 Changed 9 years ago by angel_il

  • severity changed from on review to approved

comment:10 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.