Cursor position in mcview ncurses

[egmont]

When viewing a file that no longer grows, the cursor's position is different in the slang and ncurses builds.

With slang, the cursor is in the upper right corner, on the percent sign. I think this is nice: most terminals show the cursor as a reverse colored and often blinking character cell, but it's not intrusive there.

With ncurses, the cursor wraps around to the beginning of the next line, that is, the bottom left corner of the actual file contents viewing area. I find it very intrusive there: it clutters up the space that should show me the file, and makes the first character much harder to read.

I believe the ncurses version should also move the cursor to the top row.

[egmont]

(stupid me, sorry... s/bottom left/top left/)

[egmont]

Maybe the cleanest solution is to move the percent indicator one character to the left. That way the cursor wouldn't clutter the % sign (not even with slang), it could stand on its right side (just as it does for ">= 12345 bytes" if the file is still growing).

[angel_il]

ok, i try to fix it after 4.7.2 is out...

[egmont]

view the percent by one character to the left

[egmont]

Should you choose to move the percent one character to the left, the attached patch does it, fixing the cursor position both for ncurses and slang.

If you'd like to keep the percent in the upper right corner, I think the question is how to prevent the cursor from wrapping to the next line after a tty_printf() in ncurses. Or explicitly move it back later.

[andrew_b]

Branch: 2164_mcviewer_cursor_position.
changeset:c8b72d44403e55f56bcb84d299c664d41dfb21b7

[andrew_b]

Moved to 2990_cleanup branch.

[andrew_b]

Fixed as part of #2990: [e066a25cc56b8ba1e724c9b104ba7c425241a397].