Ticket #2157 (closed defect: fixed)
ncurses vs. slang: oversized dialog backgrounds not painted in curses
| Reported by: | ralesk | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.3 |
| Component: | mc-tty | Version: | 4.7.0.4 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master committed-stable |
Description (last modified by andrew_b) (diff)
Some translations (unfortunately at this time Hungarian is one of those, I’m sorry about that :) ) make (among others) the General settings dialog big enough that it doesn’t fit on a 80×25 screen.
As such, we noticed some weird issue with the ncurses build of mc: the moment the dialog breaks up due to not being able to fit on the screen, it won’t get filled with the white colour that it usually has. In the slang build, the dialog does not become see-through even when things break into multiple lines.
One issue is then to fix the ncurses code to fill the broken dialog properly; and the other issue is to do something about dialogs so that they don’t break the way it breaks now.
Attachments
Change History
Changed 15 years ago by ralesk
- Attachment mc-broken-dialog.png added
comment:1 Changed 15 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- severity changed from no branch to on review
- Keywords stable-candidate added
- Milestone changed from 4.7 to 4.7.3
Created 2157_ncurses_fill_region branch. Parent branch is master.
changeset:690be6d5b6c4d06ffa9587b0d05f849530e5a8b8
comment:3 Changed 15 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- severity changed from on review to approved
comment:4 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko angel_il to committed-master committed-stable
- severity changed from approved to merged
- Component changed from mc-core to mc-tty
- Keywords stable-candidate removed
- Resolution set to fixed
Merged to master.
changeset:2c7bc9c1c2f9f8830114b67648ae913025d15c5f
Cherry-picked to 4.7.0-stable.
changeset:8f493101675624906487ba889a04a535b4437af7
Example of a broken dialog