Ticket #2146 (closed defect: fixed)
Misleading label "Status:" in the Info panel
| Reported by: | zaytsev | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.7.2 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master committed-stable |
Description (last modified by zaytsev) (diff)
The info panels shows useful information about the currently selected file (atime, mtime, ctime for instance). However, the label "Status:" for ctime is clearly misleading. From man 2 stat:
The field st_ctime is changed by writing or by setting inode
information (i.e., owner, group, link count, mode, etc.).
Example:
printf("Last inode change: %s", ctime(&sb.st_ctime));
As we don't have enough space to label it "Status changed", I suggest to go for "Changed:" instead. I think this will make it much clearer what this date is all about, as I have already seen users suggesting that "Status" is a weird label for "Created", which is obviously not the case.
Also, "Changed" label is consistent with "CHange time" that we use for column headers in the list mode elsewhere.
Thanks for voting!
Change History
comment:1 Changed 15 years ago by zaytsev
- Status changed from new to accepted
- severity changed from no branch to on review
- Description modified (diff)
comment:2 Changed 15 years ago by andrew_b
After rebasing: changeset:4fc8912b13c67e2864a0d5fc296dfdc1c3b82f92
comment:4 Changed 15 years ago by andrew_b
- Votes for changeset changed from slavazanko to slavazanko andrew_b
- severity changed from on review to approved
comment:5 Changed 15 years ago by zaytsev
- Keywords stable-candidate added
- Votes for changeset changed from slavazanko andrew_b to comitted-master
- severity changed from approved to merged
Committed to master. Merge changeset:0b9cddeeb75a8f7d6c9c2275dcd07785d9ac49cf.
comment:6 Changed 15 years ago by zaytsev
Cherry pick #1660 before merging to stable and regenerating PO files!!!
make -C po update-po git add po/*.po git commit -s -m 'Refresh PO-files'
comment:7 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Resolution set to fixed
comment:8 Changed 15 years ago by zaytsev
- Keywords stable-candidate removed
- Status changed from testing to closed
- Votes for changeset changed from comitted-master to committed-master committed-stable
Cherry-picked to 4.7.0-stable, changeset: e1f44066cebb059e018a3288cfe0e9b3e3f37cba .
Branch: 2146_info_status_label (parent: master)
Changeset: ebdf9a45eac63ef056d55a6a5f87c623b3829aaa
Please review!