Ticket #2137 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

Cannot change panel encoding without VFS support

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.5
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

If MC is built with --disable-vfs option, the encoding of panel cannot be changed. The error message

Cannot chdir to /<directory>/#enc:<encoding>

is raised.

In this case, chdir(2) is used to reread the directory and it treats #enc:<encoding> as a subdirectory name.
In VFS case, mc_chdir() is used and it correctly handles encoding in path to directory.

Change History

comment:1 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.4

Created 2137_panel_encoding_without_vfs branch. Parent branch is master.
Initial changeset:142ba7897b54f4e372cb765940b7d9b7f93cbff1

comment:3 Changed 9 years ago by zaytsev

  • Milestone changed from 4.7.4 to 4.7.5

comment:4 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 8 years ago by andrew_b

  • Blocking 2361 added

comment:6 Changed 8 years ago by andrew_b

  • Blocking 1512 added

comment:7 Changed 8 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:8 Changed 8 years ago by andrew_b

  • Blocking 1512 removed
  • Blocked By 1512 added

comment:9 Changed 8 years ago by andrew_b

  • Votes for changeset changed from angel_il slavazanko to committed-master
  • severity changed from approved to merged
  • Blocked By 1512 removed

comment:10 Changed 8 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.
changeset:16d17edb257f4ee6489753cdc9591f64c39432c4

git log --pretty=oneline a3b01d5..16d17ed

comment:11 Changed 8 years ago by andrew_b

  • Status changed from testing to closed
  • Blocking 2361 removed
Note: See TracTickets for help on using tickets.