Ticket #2132 (assigned defect)

Opened 9 years ago

Last modified 4 years ago

Viewer does't make horizontal scroll to the found text.

Reported by: andrew_b Owned by:
Priority: minor Milestone: Future Releases
Component: mcview Version: master
Keywords: Cc: gotar@…, egmont@…
Blocked By: Blocking: #2283
Branch state: no branch Votes for changeset:

Description

With a long lines, if the text is found for the right of the screen, viewer doesn't make horizontal scroll to the found text.

How to reproduce:

  1. Open file with long lines (Makefile of MC is good for this) in non-wrap mode.
  2. Try search '-Wno-long-long' text.
  3. Search is successful, but found text is not shown in the screen, because it is located at 235 column. but screen width is less than 235. Viewer made vertical scroll only to the line with found text.

Change History

comment:1 Changed 9 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:2 Changed 9 years ago by gotar

  • Cc gotar@… added

comment:3 Changed 8 years ago by andrew_b

  • Blocking 2283 added

(In #2283) Replying to egmont:

The logic that modifies col (e.g. col += width, col -= width etc.) assume that width and bytelenght are the same notions (because col actually means offset in the file), hence does not handle UTF-8 or CJK (double width) characters correctly.

Yes, this is the known issue. At least the #2132 ticket requires such fix.

comment:4 Changed 7 years ago by slavazanko

  • Owner slavazanko deleted
  • Status changed from accepted to assigned
  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:5 Changed 4 years ago by andrew_b

Ticket #3421 has been marked as a duplicate of this ticket.

comment:6 Changed 4 years ago by egmont

  • Cc egmont@… added
Note: See TracTickets for help on using tickets.