Ticket #2125 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

User asked twice about overwriting file

Reported by: bilbo Owned by: bilbo
Priority: major Milestone: 4.7.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

When file is moved across filesystems and destination file exists, user is asked twice whether to overwrite file or not.

Root cause: commit 804ca8e7b0d23937ca578659b1840f88e60fe931 "Added indication of total BPS and ETA for file operations"

Before, when move failed (source & target on different filesystems ...), copy & delete was used, but parameter ask_overwrite was set to false when calling copy_file_file. In that commit, that parameter is moved to tctx and it is not set to false in that case.

Change History

comment:1 Changed 9 years ago by bilbo

  • severity changed from no branch to on review

Created branch 2125_ask_overwrite_twice with fix of the problem.

Please review.

comment:2 Changed 9 years ago by bilbo

  • Status changed from new to accepted

comment:4 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:5 Changed 9 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:6 Changed 9 years ago by bilbo

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset: 13e3c684bd899daff63d2c16e7fc5511e67c7474

comment:7 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.