Ticket #2101 (closed enhancement: fixed)

Opened 7 years ago

Last modified 4 years ago

Show current count in "Directory scanning"

Reported by: gotar Owned by: andrew_b
Priority: minor Milestone: 4.8.8
Component: mc-core Version: master
Keywords: Cc: foxrocks08@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

'Show directory sizes' function has new dialog with directory names and ability to abort. It could be improved to show directory count and current size sum as well.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Version changed from version not selected to master
  • Blocked By 2136 added

comment:2 Changed 6 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:3 Changed 4 years ago by foxrocks

  • Cc foxrocks08@… added

User should be able to disable this feature. Sometimes it's useful, but mostly it can be rather annoying. So I think a "Skip" button would be very useful besides the "abort" button when directory scanning is in progress.

I want midnight commander to delete files, and I hate waiting several minutes only to know that the delete operation will take another few minutes.

comment:4 Changed 4 years ago by gotar

Skipping counting over particular directory might be nice feature indeed (not aborting entire operation).

However your 'delete' problem is resolved eons ago - just disable 'Compute totals'.

comment:5 Changed 4 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Blocked By 2136 removed

comment:6 in reply to: ↑ description ; follow-up: ↓ 7 Changed 4 years ago by andrew_b

Replying to gotar:

It could be improved to show directory count and current size sum as well.

I don't think so. What is it useful for? Total size and number of files you can see in the copy/move progress dialog immediately after directory scan.

comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed 4 years ago by gotar

Replying to andrew_b:

I don't think so. What is it useful for?

To know that I've marked already too much and wish to abort now.
To have _some_ idea about progress (knowing my disk size, or expecting some value around sth).
To see that network connection has stalled or is too slow to continue (so I should abort).

Otherwise - what's the point of printing currently scanned directory name? It flashes anyway, so noone would read it's name anyway.

Total size and number of files you can see in the copy/move progress dialog immediately after directory scan.

'Immediately after' might be 2 minutes or 200 minutes from the beginning or any moment meanwhile scanning.

Oh, and this ticket is about Show Directory Sizes _command_ - ctrl-space, not option used for file operations.

comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 4 years ago by andrew_b

Replying to gotar:

Otherwise - what's the point of printing currently scanned directory name? It flashes anyway, so noone would read it's name anyway.

To make some visualization of process: we are doing something but not hanging.

'Immediately after' might be 2 minutes or 200 minutes from the beginning or any moment meanwhile scanning.

The 'Skip' button will be added as requested above.

Oh, and this ticket is about Show Directory Sizes _command_ - ctrl-space, not option used for file operations.

The code of dir scan is same in both cases.

comment:9 in reply to: ↑ 8 Changed 4 years ago by gotar

Replying to andrew_b:

Otherwise - what's the point of printing currently scanned directory name? It flashes anyway, so noone would read it's name anyway.

To make some visualization of process: we are doing something but not hanging.

The same reason is valid for counts - it's even better, as we see actually growing numbers, not rapidly changing and unreadable names of something deep deep in directory tree.

I've got storages that took half an hour to scan, while most of this time was wasted on some /var/spool/whatever-zillion-small-or-0-sized-files. Size printed _while_ scanning might be enough in some cases ('ok, THIS ate my missing TB').

comment:10 Changed 4 years ago by andrew_b

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.8

Branch: 2101_skip_directory_scanning (parent: master).
Initial changeset:1832b63cbbb08d93cd19b9e30f3e38870dbe77a7

Last edited 4 years ago by andrew_b (previous) (diff)

comment:11 Changed 4 years ago by andrew_b

  • Branch state changed from on review to on rework

comment:12 Changed 4 years ago by andrew_b

  • Branch state changed from on rework to on review

comment:13 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:14 Changed 4 years ago by andrew_b

  • Votes for changeset slavazanko deleted
  • Branch state changed from on review to on rework

comment:15 Changed 4 years ago by andrew_b

  • Branch state changed from on rework to on review

Review and vote again, please.

comment:16 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:17 Changed 4 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:18 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [4bbeaf9f38edbf850f8a3189f19642b16a2ed000].

git log --pretty=oneline 430e1f9..4bbeaf9

comment:19 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.