Ticket #2097 (accepted task) — at Version 13

Opened 14 years ago

Last modified 14 years ago

Cleanup for current master

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.7.2
Component: mc-core Version: 4.7.1
Keywords: code cleanup Cc: zaytsev
Blocked By: Blocking: #1949, #2041, #2078, #2119
Branch state: Votes for changeset:

Description (last modified by angel_il) (diff)

Clean-up-of-4.7.1-assignments-02.diff is not git patch

Change History

Changed 14 years ago by vit_r

getting-out-assignments-from-some-ifs

comment:1 Changed 14 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to wontfix
  • Description modified (diff)

No need special ticket for this. This clean up will make with lowest priority simultaneously with other work.

comment:2 Changed 14 years ago by slavazanko

  • Keywords code cleanup added
  • Type changed from enhancement to task
  • Status changed from closed to reopened
  • Resolution wontfix deleted
  • Summary changed from Clean-up-of-4.7.1-outing-assignments to Cleanup for current master

Ticket stil alive until next release out.

Ticket will contain just cleanup/indentation thinks

Changed 14 years ago by vit_r

src/help.c interactive_display () removing UN used argument

comment:3 Changed 14 years ago by andrew_b

attachment 2097-src-help.c-interactive_display-rm-UNused-argument.patch added

This patch must not be applied due to #1561.

Changed 14 years ago by vit_r

some-unused-lines-in-mc-4.7.1

Changed 14 years ago by vit_r

Changed 14 years ago by vit_r

Changed 14 years ago by vit_r

some-unused-in-mc-4.7.1-lines-2

comment:4 Changed 14 years ago by vit_r

2097-some-unused-in-mc-4.7.1-lines-2.diff
in src/panelize.c just renaming

-    external;
+    eksternal;

comment:5 Changed 14 years ago by vit_r

2097-getting-rid-of-else_return-in-mc-4.7.1.diff

  • lib/vfs/mc-vfs/fish.c
  • lib/vfs/mc-vfs/vfs.c

In mc_opendir() lines are left unaligned to clearly show that:

	"Only minor changes are made"

Even revealed bugs are left as next step :-)

Changed 14 years ago by vit_r

comment:6 Changed 14 years ago by andrew_b

Created 2097_cleanup_master branch. Parent branch is master.

comment:7 Changed 14 years ago by andrew_b

  • Blocking 2119 added

(In #2119) Most parts are applied in #2097.

comment:8 Changed 14 years ago by andrew_b

  • Blocking 2078 added

(In #2078) Applied with some modifications in #2097.

comment:9 Changed 14 years ago by andrew_b

  • Blocking 2041 added

(In #2041) Applied with some modifications in 2097.

comment:10 Changed 14 years ago by andrew_b

  • Blocking 1949 added

(In #1949) Applied in #2097.

Changed 14 years ago by vit_r

src-find.c-subshell.c-mem-leaks

comment:11 Changed 14 years ago by andrew_b

attachment 2097-src-find.c-subshell.c-mem-leaks.diff added

There are no memleaks there.

comment:12 Changed 14 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from reopened to accepted

comment:13 Changed 14 years ago by angel_il

  • Description modified (diff)

Changed 14 years ago by zaytsev

Rewording of the changelog.

Note: See TracTickets for help on using tickets.