Ticket #2091 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Superfluous "Search done, Continue from begining?" dialog

Reported by: gotar Owned by: slavazanko
Priority: trivial Milestone: 4.7.2
Component: mcview Version: 4.7.1
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

When searching from the top of the file for something that's not there we get "Search done, Continue from begining?" dialog before "Search string not found" (and only if we choose "Yes" in the first one).

This should happen only if the last position>0 (either the place when search began, or some match before).

Change History

comment:1 Changed 9 years ago by gotar

I forgot to mention #1917 as related.

comment:2 Changed 9 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • Milestone changed from 4.7 to 4.7.2

comment:3 Changed 9 years ago by slavazanko

  • Version changed from version not selected to 4.7.1
  • severity changed from no branch to on review

Create branch 2091_viewer_search (parent: master)

Initial changeset:c854b13ba5dea6e98332cd4c52910cf7f707af3c

Review, please.

comment:4 Changed 9 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:5 Changed 9 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • severity changed from on review to approved

comment:6 Changed 9 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

master:7ca06cb5232a15974b967fe24231858f567813cf

comment:7 Changed 9 years ago by slavazanko

  • Status changed from testing to closed

comment:8 Changed 9 years ago by zaytsev

  • Cc zaytsev added

What about backwards search? Any idea why it does not wrap???

Note: See TracTickets for help on using tickets.